In pulls.get, getting error 'mediaType' does not exist in type 'PullsGetParams'

Bug Report

Current Behavior When trying to typescript-compile the below code, getting Argument of type '{ owner: string; repo: string; pull_number: any; mediaType: { format: string; }; }' is not assignable to parameter of type 'PullsGetParams'.

import { Application } from 'probot' // eslint-disable-line no-unused-vars

export = (app: Application) => {
  app.on('pull_request.opened', async (context) => {
    const issue = context.issue()
    const pr = await context.github.pulls.get({
      owner: issue.owner,
      repo: issue.repo,
      pull_number: issue.number,
      mediaType: {
        format: 'diff'
      }
    })

    console.error(pr)
  })
}

Expected behavior/code Should be able to compile and run, according to docs from @octokit/rest: https://octokit.github.io/rest.js/ Excerpt:

const { data: diff } = await octokit.pulls.get({
  owner: "octokit",
  repo: "rest.js",
  pull_number: 123,
  mediaType: {
    format: "diff"
  }
});

Environment

• Probot version(s): v9.5.0
• Node/npm version: node v10.16.0
• OS: macOS

[qnnguyen17]

The problem might be pull_number: any. Can you try this?

    pull_number: issue.number as number

Thanks for taking a look! I changed the code to your suggestion:

    await context.github.pulls.get({
      owner: issue.owner,
      repo: issue.repo,
      pull_number: issue.number as number,
      mediaType: {
        format: 'diff'
      }
    })

And I’m getting the following error:

No overload matches this call.
  Overload 1 of 2, '(params?: PullsGetParamsDeprecatedNumber | undefined): Promise<Response<PullsGetResponse>>', gave the following error.
    Argument of type '{ owner: string; repo: string; pull_number: number; mediaType: { format: string; }; }' is not assignable to parameter of type 'PullsGetParamsDeprecatedNumber'.
      Object literal may only specify known properties, and 'pull_number' does not exist in type 'PullsGetParamsDeprecatedNumber'.
  Overload 2 of 2, '(params?: PullsGetParams | undefined): Promise<Response<PullsGetResponse>>', gave the following error.
    Argument of type '{ owner: string; repo: string; pull_number: number; mediaType: { format: string; }; }' is not assignable to parameter of type 'PullsGetParams'.
      Object literal may only specify known properties, and 'mediaType' does not exist in type 'PullsGetParams'.

[qnnguyen17]

Thank you so much for the quick response and fix!