"Invalid GitHub App configuration" error: properties/url is not a string

Bug Report

Current Behavior After clicking “Register GitHub App”, the https://github.com/settings/apps/new page shows an error

Above: Screenshot of the error.

Invalid GitHub App configuration

The configuration does not appear to be a valid GitHub App manifest.

Error For ‘properties/url’, {“type”=>“git”, “url”=>“[e-mail]:Financial-Times/tako.git”} is not a string.

Expected behavior I expect the https://github.com/settings/apps/new page not to throw any errors.

Above: Screenshot of expected behaviour 😃

Environment

• Probot version(s): { “probot”: “7.4.0” }
• Node/npm version: Node v10.15.0
• OS: OSX 10.14.2
• Chrome Version 71.0.3578.98 (Official Build) (64-bit)

Possible Solution I’m not sure, but it might be to somehow make the URL a string in the getManifest method in the ManifestCreation class: https://github.com/probot/probot/blob/master/src/manifest-creation.ts#L52

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gr2m]

Ah okay I got it. I’d say let’s just remove || pkg.repository.url as suggested by @sjparkinson