Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Porting probot-config into Probot proper

See original GitHub issue

Why do we need org wide configuration?

For some history on org wide configuration and why it’s needed check out this dinosaur: https://github.com/probot/probot/issues/258

Current state of things

Right now org wide configuration require installing a separate probot extension, probot-config.

We do, however, have a built-in internal API for getting a config file for the repo an App is acting on. That method is context.config() and it takes a file name (located in the .github/ folder) and loads the contents of the yml file into an object.

Any time an app wants to add support for org-wide management, they have to require probot-config and using that to load their configuration files.

The future

It would be pretty amazing if org support was just built into probot, so that no apps need to update their code to support it. (aside from bumping their probot version?)

What this would look like: context.config() method would use probot-config under the hood.

Would love any 💭 or 👍 👎 🎉 ❤️ 😆

cc/ @probot/maintainers cc/ @jan-auer (original probot-config creator)

Issue Analytics

State:
Created 5 years ago
Reactions:5
Comments:12 (10 by maintainers)

Top GitHub Comments

1reaction

gr2mcommented, Aug 5, 2019

The Welcome app is still running on Probot 7, the source code is here: https://github.com/behaviorbot/welcome/

It’d be great to update it and the other apps it depends on to the latest Probot. Once we have that working, we can setup continuous deployment. Bex added me as admin to the @behaviorbot org so I merge PRs

<div> GitHub</div><div>behaviorbot/welcome</div><div>A probot app that welcome new users. Contribute to behaviorbot/welcome development by creating an account on GitHub.</div>

0reactions

gr2mcommented, Aug 5, 2019

Also, do you have any sense of the frequency that GitHub App hosted versions of Probot apps (I’m particularly interested in the Welcome app) get updated to new releases of Probot?

I do not know that, I’m actually not sure how these are deployed. But find out. Maybe ideally they would be deployed with each new GitHub version? We could pin the probot version in the dependencies and use Greenkeeper to update to the latest probot with each release. As long as automated deployment is setup this should just work ™️

Top Results From Across the Web

The configuration issue to end all configuration issues #258

Configuration for probot has always been difficult. For context, originally, the goal of probot was to use only information from GitHub ...

ProBot Commands

Are you new to ProBot and want to know about all the commands and their usage? You've come to the right place! All;...

A Wild Probot Appeared | Product Blog • Sentry

While probot-config is by far not complete, it is certainly a good start in the right direction. Finally — and this is not...

Pro-Bot - Terrapin Logo

Insert the USB cable into the charging socket on the rear of your Pro-Bot. Connect the other end to a spare USB port...

Settings app - Probot

# Collaborators: give specific users access to this repository. ... # Note: Only valid on organization-owned repositories. # The permission to grant the ......