Post Probot v10 todos

See original GitHub issue

The upcoming v11 release is all about making probot easier to run in a serverless/function environment, please join the v11 roadmap discussion at https://github.com/probot/probot/issues/1286

Todos

These are a follow up to #1274

done

Create a probot-specific Octocit authentication strategy that combines @octokit/auth-app, @octokit/auth-token and @octokit/auth-unauthenticated so that the handling of the different authentication environments and contexts can be centralized in one place
- plugin is done https://github.com/probot/octokit-auth-probot
- use plugin in probot #1392
Create an Octokit plugin for the context.config logic.
- plugin is done: https://github.com/probot/octokit-plugin-config
- use plugin in probot
options.throttleOptions should not be necessary for Probot and Application constructor. It should live in the ProbotOctokit defaults (https://github.com/probot/probot/pull/1365)
Combine Probot and Application. See discussion at https://github.com/probot/probot/issues/1398
Move all access of process.env to Probot.run(). Environment variables should be accessed in CLI usage only. Replace them with options for the Probot constructor. #1415
Refactor tests so we don’t have to make probot.options public
Deprecate context.github in favor of context.octokit #1413
Create separate module to retrieve private key (see https://github.com/probot/probot/blob/2b30518fbda0adc5a0e06a89ecdc4099a8b229fa/src/helpers/get-private-key.ts) #1414
deprecate server related method on Probot: probot.setup(), probot.start(), probot.stop(), probot.load() #1420

follow up issues

Issue Analytics

State:
Created 3 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

gr2mcommented, Dec 8, 2020

I think the remaing todos can be pushed to v11, I’ll make follow up issues. They do not affect the serverless APIs.

0reactions

cchantepcommented, Sep 21, 2020

Right, but the same issue will apply to this update as octokit dependencies are again updated there.

An octokit, typescript bindings/types about request and response are updated, without much documentation (e.g. how to update typescript imports).

Top Results From Across the Web

Move all access of process.env to run #1415 - GitHub

part of #1309 The Probot class shouldn't access any environment variables. Handling environment variables ... Post Probot v10 todos #1309.

ProBot Commands

Welcome images, moderation, leveling, reaction roles, logs, high quality music and many many more!

Probot (@ProbotTheRobot) / Twitter

Once Probot v10 is released (#1274), we will focus on Making Probot work well in function/serverless environments, including AWS Lambda (see existing adapter: ......

Untitled

Trevor noah pronunciation, Postal 2 apocalypse weekend chomikuj, Fikse wheels for ... Ga 60xt bios, Intel 915g ich6r chipset, Yo confundo todo con...

Build your own Probot | Jason Etcovitch

I'm hoping that from this post, you (yes you!) will get an ... When an event happens on GitHub that your Probot app...