p5.Signal question --> remove it

in the codebase https://github.com/processing/p5.js-sound/blob/e5a58ba1e3efa6f65c60da7a4513178fffa2df32/src/signal.js#L82

shouldn’t it be p5.Signal.prototype.fade = Signal.prototype.linearRampToValueAtTime; otherwise we are adding the fade method to the tone.js Signal API , seems bit confusing to me 😕

[therewasaguy]

great find @endurance21. I think that p5.SignalAdd, as well as p5.Signal, are undefined properties of p5…yikes! That’s a good thing as we don’t need to check for instances of p5.Signal. If this means some functionality is broken, we should make a note of that and revive it. If it’s beyond the scope of the initial PR (and something that has not been working for a while) we can make that its own issue/PR.

By the way, the screenshots are useful, but I’ll find it easier to review if you can paste a link to the lines that you want to reference so that I can view the full context.

https://github.com/processing/p5.js-sound/blob/master/src/pulse.js#L109-L114

^ In this case, seems like we can replace the internal usage with a Tone Signal

[therewasaguy]

That seems to be the thought I had in 2014, but we haven’t had requests for it, so I don’t think it’s a feature we should add. Adding features also means more maintenance and makes the library more confusing when people look at the documentation. If anything, I think we should be removing features.