question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Removing dist from the repository

See original GitHub issue

I’m not sure it’s really correct to have the distribution in the repository - can it not be built immediately prior to being uploaded to the website?

Running git status after a build with no changes currently gives:

$ git status
On branch master
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   dist/assets/css/all.css
	modified:   dist/assets/css/maps/all.css.map
	modified:   dist/offline-reference/p5-reference.zip

no changes added to commit (use "git add" and/or "git commit -a")

And after erasing dist/ (I know I should have used grunt clean but I am used to having builds that you can remove the output folder and it comes out the same)

On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   dist/assets/css/all.css
	modified:   dist/assets/css/maps/all.css.map
	deleted:    dist/assets/helpers/release.php
	deleted:    dist/assets/helpers/version.json
	modified:   dist/assets/img/asterisk-01-01.png
	modified:   dist/assets/img/asterisk-01.png
	modified:   dist/assets/img/books/gettingstarted.png
	modified:   dist/assets/img/cc_88x31.png
	deleted:    dist/assets/img/debugging/0-0.jpg
        [... snip some deleted files ...]
	deleted:    dist/assets/img/debugging/9-1.jpg
	modified:   dist/assets/img/learn/3d.jpg
	modified:   dist/assets/img/libraries/dom.jpg
	modified:   dist/assets/img/libraries/grafica.jpg
	modified:   dist/assets/img/libraries/p5.bots.jpg
	modified:   dist/assets/img/libraries/p5.geolocation.png
	modified:   dist/assets/img/libraries/p5.gibber.jpg
	modified:   dist/assets/img/libraries/p5.gif.gif
	modified:   dist/assets/img/libraries/p5.particle.png
	modified:   dist/assets/img/libraries/p5.play3.png
	modified:   dist/assets/img/libraries/p5.speech.jpg
	modified:   dist/assets/img/libraries/rita.png
	modified:   dist/assets/img/libraries/sound.jpg
	modified:   dist/assets/img/p5js-beta.svg
	modified:   dist/assets/img/p5js.svg
	modified:   dist/assets/img/search.png
	modified:   dist/assets/img/test-image-0.jpg
	modified:   dist/assets/img/test-image-1.jpg
	modified:   dist/assets/img/thick-asterisk-alone-gray.svg
	modified:   dist/assets/img/thick-asterisk-alone.svg
	deleted:    dist/assets/img/tutorials/debugging/0-0.jpg
        [... snip a lot of deleted files ...]
	deleted:    dist/reference/modules/p5.sound.html

no changes added to commit (use "git add" and/or "git commit -a")

Which implies to me that the build is not fully repeatable. I don’t know if this is that much of a problem (And I saw #108 just now after being confused why my diff was so huge working on a recent PR) but I think it’s probably best to remove dist/ if at all possible.

Is it possible to set this as something to aim for?

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:1
  • Comments:17 (17 by maintainers)

github_iconTop GitHub Comments

1reaction
limzykennethcommented, Jan 22, 2019

We can probably put it in src/ but we’ll need a copy step in grunt to copy it into dist/ on build.

1reaction
lmccartcommented, Jan 17, 2019

thanks for this. I’ve started removing things chunk by chunk, so far site is looking good. thanks so much @meiamsome for figuring this out, it’s definitely a big improvement over the old system. looking forward to getting things fully cleaned up and sorted.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Best method to remove dust from image #2440 - GitHub
i have tried a number of the mathematically methods to remove the dust but I haven't been able to figure out one that...
Read more >
effectiveness-of-dust-mitigation-and-cleaning-strategies.pdf
This research demon- strates that there is cause for cleaning hands as often as possible while handling archival documents to minimise the risk ......
Read more >
Make your repository lean and clean! - Codeac
An alternative way to clean large files from your repository is to use git-filter-repo . It is a versatile tool for altering GIT...
Read more >
The effectiveness of dust mitigation and cleaning strategies at ...
Cotton cloths, microfiber cloths, and lamb's wool dusters are used for collection material while metal shelving is cleaned using a fine mist of...
Read more >
Here's How to Clean Git and Remove Untracked Files
Learn how to clean your Git. PC screen displaying a GitHub repository. Untracked files can clutter up your Git working tree and mess...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found