Ambiguous PSQL function when `delete_job` undefined

Summary

When delete_job of the current procrastinate_finish_job function is None, the current procrastinate_finish_job, defined here, becomes ambiguous with the old(est) one defined here.

Trace

The resulting bug looks like:

  File "aiopg/connection.py", line 106, in _ready
    state = self._conn.poll()
psycopg2.errors.AmbiguousFunction: function procrastinate_finish_job(integer, unknown, unknown) is not unique
LINE 1: SELECT procrastinate_finish_job(4, 'succeeded', NULL);
               ^
HINT:  Could not choose a best candidate function. You might need to add explicit type casts.

The above exception was the direct cause of the following exception:

[...]
 File "/procrastinate/worker.py", line 171, in process_job
    await self.job_manager.finish_job(
 File "/procrastinate/manager.py", line 135, in finish_job
    await self.connector.execute_query_async(
 File "/procrastinate/aiopg_connector.py", line 35, in wrapped
    raise exceptions.ConnectorException from exc
procrastinate.exceptions.ConnectorException: 
    Database error.

Sadly, I don’t have a minimal example for reproduction at the moment. The error occured when starting one worker after a job was deferred.

A possible solution would be enforcing a boolean value of the delete_job param of finish_job.

[BracketJohn]

Sure thing.

From our perspective no worries - migrating to 0.18 is no problem/was already done, just not locally. However, I do see that this may be a problem for others and for the contract you’ve defined.

[elemoine]

Thanks for confirming that the failing instance ran on v0.17.x. That makes more sense now. We’ll see how we can fix that. Sorry for the trouble.