question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`AsDiscreted` bug when `threshold=0.0`

See original GitHub issue

Reproduce the bug:

from monai.transforms import AsDiscreted
a = AsDiscreted(keys="pred", threshold=0.0)
Screen Shot 2021-11-23 at 10 56 39 PM

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
Nic-Macommented, Nov 24, 2021

Hi @yiheng-wang-nv ,

I submitted PR #3393 to fix it and added more unit tests to cover the threshold=0.0 case. The call() function of array transform is already covered by the dict transform, because: https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/post/dictionary.py#L204 Could you please help review it?

Thanks in advance.

0reactions
Nic-Macommented, Nov 24, 2021

Hi @yiheng-wang-nv ,

Thanks for your test, let me have a try and investigate it ASAP.

Read more comments on GitHub >

github_iconTop Results From Across the Web

AsDiscrete transform not working with threshold #3426 - GitHub
This seems like the bug I've reported in Project-MONAI/tutorials#463. I solved it by just renaming the threshold argument by logit_thresh:
Read more >
Transforms — MONAI 1.1.0 Documentation
Defaults to 0.0. prob_threshold ( float ) – the probability threshold, the function will stop searching if the highest probability is no larger...
Read more >
Chapter 8--Threshold Channel Design - Directives - USDA
A threshold channel is a channel in which movement of the channel boundary material is negligible during the design flow. The term threshold...
Read more >
General Purpose Plotting of Nonparametric Objects - R
Defaults to 0.0 . See details. neval, an integer specifying the number of evaluation points. Only applies to continuous variables however, as discrete...
Read more >
Ion v2.0 Operations Manual
problem. WARNING: A Warning statement indicates situations where damage may occur ... The editor does not limit how many frames you can add...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found