question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve bundle doc for the `import` logic

See original GitHub issue

Is your feature request related to a problem? Please describe. Thanks for @diazandr3s 's feedback, it’s not clear in the bundle doc that:

  1. Which class names can be used in _target_ directly, which class should provide the full module path? answer: MONAI classes and functions can be used directly.
  2. When using import in the config, which packages are pre-imported? seems monai, np, torch. answer: yes, the default behavior of ConfigParser will import monai, numpy, np, torch as these are MONAI min deps.
  3. Should I import the components in the config? Like transforms, network, etc. answer: only need to import 3rd libs for expressions, not for _target_ instantiation.

Would be nice to enhance the bundle doc for these points.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
diazandr3scommented, May 17, 2022

I missed this part of the question:

What do you guys feel when you started to develop a bundle? Do you want to refer to the documentation page or tutorial notebook?

I’d suggest having that in the Notebook format

I’ve created the DeepEdit bundle based on the already developed bundle for Spleen segmentation and the Notebook mostly. The development is easier when you have a JSON parser (i.e. online)

1reaction
Nic-Macommented, May 17, 2022

Hi @wyli ,

I think maybe we should provide the page for all the details of syntax with examples, then users just search this page for any syntax questions. Refer to the omegaconf: https://omegaconf.readthedocs.io/en/2.1_branch/usage.html#creating Many examples of bundle syntax can be found in this slides: https://docs.google.com/presentation/d/1qXl5-GT14kST68RDCJ408ilMpiHDCAN1QnecuRoqyZI/edit?usp=sharing

The tutorial notebook is just one practice example which can’t cover all cases.

Anyway, I am open for the discussion. @ericspod @diazandr3s What do you guys feel when you started to develop a bundle? Do you want to refer to the documentation page or tutorial notebook?

Thanks.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Import data and settings from other Logic Pro projects
Import settings from another project​​ In Logic Pro, do one of the following: Choose File > Project Settings > Import Project Settings (or...
Read more >
Code Splitting - webpack
This feature allows you to split your code into various bundles which can then be ... Dynamic Imports: Split code via inline function...
Read more >
The 100% correct way to split your chunks with Webpack
Bundle splitting: creating more, smaller files (but loading them all on each network request anyway) for better caching. Code splitting: dynamically loading ...
Read more >
Angular - How to improve bundle size?
Is your Angular application slow? Here are 5 ways you can reduce the bundle size. And make it load faster. · 1. Investigate...
Read more >
API - ESBuild
To join a set of files together with esbuild, import them all into a single entry point file and bundle just that one...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found