Wrap: Allow annotations parameter to accept specific fields
See original GitHub issueThe annotations
parameter changed form a bool
to specific annotation types.
We need to wrap this in node-osrm
, too.
Upstream:
- Issue https://github.com/Project-OSRM/osrm-backend/issues/3563
- Pull Request https://github.com/Project-OSRM/osrm-backend/pull/3628
Tasks
-
node_osrm.cpp
adapt comments -
node_osrm_support.hpp
parse from Javascript-land - adapt
docs/api.md
Here’s the entry point where we throw an exception currently.
cc @karenzshea
Issue Analytics
- State:
- Created 7 years ago
- Comments:7 (7 by maintainers)
Top Results From Across the Web
Wrap function implementations returning a specific type into ...
I would like to wrap all the user defined functions in a scala project that return a certain type T , into a...
Read more >Creating Annotations in Java - DZone
This annotation has a single parameter, value , of type String with a default value of an empty string.
Read more >An Introduction to Annotations and Annotation Processing in ...
Annotations provide information to a program at compile time or at runtime based on which the program can take further action.
Read more >Jackson Annotation Examples - Baeldung
The @JsonAnyGetter annotation allows for the flexibility of using a Map field as standard properties. For example, the ExtendableBean entity ...
Read more >How to bind @RequestParam to object in Spring - Dev in Web
Validating request parameters inside POJO ... Alright, but we don't use the @RequestParam annotation only to bind HTTP parameters. Another useful ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
So shall we accept
bool
or anarray of string
?Then, I will accept
I will not accept
?
@karenzshea @TheMarex
@chaupow I would suggest not allowing string values but only boolean and array of strings to keep the API surface small.