question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Wrap: Allow annotations parameter to accept specific fields

See original GitHub issue

The annotations parameter changed form a bool to specific annotation types. We need to wrap this in node-osrm, too.

Upstream:

Tasks

  • node_osrm.cpp adapt comments
  • node_osrm_support.hpp parse from Javascript-land
  • adapt docs/api.md

Here’s the entry point where we throw an exception currently.

cc @karenzshea

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
chaupowcommented, Feb 13, 2017

So shall we accept bool or an array of string?

Then, I will accept

var options = {
    annotations: true
};
var options = {
    annotations: ['distance', 'weight', 'node']
};
var options = {
    annotations: ['distance']
};

I will not accept

var options = {
    annotations: 'distance'
};
var options = {
    annotations: [true]
};

?

@karenzshea @TheMarex

1reaction
TheMarexcommented, Feb 11, 2017

@chaupow I would suggest not allowing string values but only boolean and array of strings to keep the API surface small.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Wrap function implementations returning a specific type into ...
I would like to wrap all the user defined functions in a scala project that return a certain type T , into a...
Read more >
Creating Annotations in Java - DZone
This annotation has a single parameter, value , of type String with a default value of an empty string.
Read more >
An Introduction to Annotations and Annotation Processing in ...
Annotations provide information to a program at compile time or at runtime based on which the program can take further action.
Read more >
Jackson Annotation Examples - Baeldung
The @JsonAnyGetter annotation allows for the flexibility of using a Map field as standard properties. For example, the ExtendableBean entity ...
Read more >
How to bind @RequestParam to object in Spring - Dev in Web
Validating request parameters inside POJO ... Alright, but we don't use the @RequestParam annotation only to bind HTTP parameters. Another useful ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found