Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Auto-update PR branches instead of anti-tamper

See original GitHub issue

As we venture deeper into the world of checked-in synthesized outputs and snapshot tests, I am wondering if instead of failing on anti-tamper checks in PR branches, we should simply push any changes back.

Basically automatically use @projen rebuild.

In almost every case, this is what users would want to do.

Issue Analytics

State:
Created 3 years ago
Reactions:5
Comments:13 (13 by maintainers)

Top GitHub Comments

2reactions

eladbcommented, Dec 16, 2020

@smacintyre Thanks for the inputs. I really appreciate you taking the time.

How about this? I’ll add this feature and by default it will only be enabled for PRs with a certain label applied to them. If the label is not applied, and anti tamper failed, the workflow will post a comment explaining why the build failed and will also propose to slap the label if users want auto updates.

Additionally we’ll add a switch that will allow enabling this for all PRs.

This way we will be able to meet experiment with this and see how it feels to have this capability without surprising users and also providing good discoverability.

1reaction

pgolluccicommented, Dec 16, 2020

I can’t argue with that @smacintyre.