[bug] TypescriptApp: Release task runs git diff in the wrong context
See original GitHub issueThis should be a fairly minor bug.
Issue
The release task runs this command:
👾 release | git diff --ignore-space-at-eol --exit-code
However, if the project project is not at the root of the git repo, it fails for unrelated diffs.
Fix
The release task should run this command:
👾 release | git diff ./ --ignore-space-at-eol --exit-code
This should solve both the case where it’s running at the root of the project and not at the root of the project.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:3
- Comments:5 (2 by maintainers)
Top Results From Across the Web
'git status' shows changed files, but 'git diff' doesn't
I was able to fix this problem by adding all files to the index and then resetting the index. git add -A git...
Read more >simple-git
A lightweight interface for running git commands in any node.js application. Version 3 - Out Now. From v3 of simple-git you can now...
Read more >IntelliJ IDEA 2019.3.1 (193.5662.53 build) Release Notes
Gradle tests report in IDE: merge test results from different tasks and workers. Bug, IDEA-226433, Regression on working with Android gradle sub-projects that ......
Read more >API Reference | projen
GitpodTask, Configure options for a task to be run when opening a Gitpod workspace (e.g. running tests, ... Log a message to stderr...
Read more >T9929 arc diff/export generate wrong GIT patch when file is ...
I find a bug in Arcanist. I used arc diff to generate a revision, I found arc generate a wrong GIT patch, cause...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
An example can be observed here after chaining the readme in main:
https://github.com/cloudy-with-a-chance-of-meatballs/cdk-lambda-token-authorizer-jwt/actions/runs/3448987353/jobs/5756509741
Still seeing this issue. Any idea how to resolve this?
thanks!