Issue with sessionduration since latest v3.1. Extension is not working

There is an issue in latest version 3.1, in script.js file inside onBeforeRequestEvent function sessionduration is not defined because of that it is not working please fix this asap.

let sessionduration = undefined;

[prolane]

With the refactoring of the code due to Chrome Extension manifest V3 there was indeed a bug introduced related to the sessionduration. I was able to reproduce the issue. You’ll encounter this issue when your IDP does not add a Session Duration as one of the SAML Assertion attributes.

This is now fixed with this: https://github.com/prolane/samltoawsstskeys/blob/86a2c87b8bd2c680166b5da553b6e616967e1bfc/background/script.js#L143

I’ll publish v3.2 tonight in the Chrome web store.

Please let me know if this indeed fixed it for you.

[prolane]

@shubhkb I agree with you I should declare the variable in a next updated version and I will. For now I don’t think it will make any functional difference, does it? The sessionduration variable will implicitly be a global variable due to: https://github.com/prolane/samltoawsstskeys/blob/86a2c87b8bd2c680166b5da553b6e616967e1bfc/background/script.js#L116

If your IDP does not include the SessionDuration Attribute, the sessionduration will be typeof ‘undefined’ as now checked on that line 143 where the error occurred. https://github.com/prolane/samltoawsstskeys/blob/86a2c87b8bd2c680166b5da553b6e616967e1bfc/background/script.js#L143