Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Promises Do Not Queue

See original GitHub issue

On L109, inside thePromise the .add() method returns, you call ._dequeue(), assumedly to begin processing the Promises. What this causes is for every added Promise to dequeue as soon as it is actually queued.

This should only ever happen if there aren’t any currently pending. If there are pending Promises, the recursive method will reach them eventually anyway. It would fail this test having them resolve in time order, not in the order they were queued.

Issue Analytics

State:
Created 6 years ago
Comments:6

Top GitHub Comments

5reactions

azproductioncommented, Jan 29, 2018

Your “Queue” does nothing.

@Crowes I don’t see your point. Are you trying to help or you came to insult this project and it’s contributors?

0reactions

InsertBeforeFlightcommented, Jan 29, 2018

Noticed your commit, thanks for testing that.

I’m trying to figure out how you’re avoiding ._dequeue() just instantly calling the promiseGenerator as soon as it’s added, considering L109; realistically that only needs to happen to get recursion (that is caused by the same call on L160 f/e) going. With it being called all the time, L160 becomes redundant, I’d assume, because they’ll all have been shifted by that point.

If you call L109 only when .pendingPromises is 0, then L160 will be relied on, unless it’s the first addition since onEmpty.