question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Don’t have a nazi symbol as default length

See original GitHub issue

Black defaults to 88 characters per line, which happens to be 10% over 80.

It also happens to be a nazi symbol.

While having a nazi symbol in a project called “black” may sound funny to some, me included, I suggest switching to something else, even if it’s just 87 or 89.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:9
  • Comments:7 (1 by maintainers)

github_iconTop GitHub Comments

2reactions
knyghtycommented, Dec 6, 2019

@onlinejudge95 the problem here is not “people overthinking stuff” but people having an immediate and perhaps involuntary discomfort seeing the number.

I don’t really have a problem with it either way, but I think overreacting to other people’s feelings isn’t helpful either.

Personally, I think PEP8 is great, but it’s not the bible, it’s not some inevitable truth, it was written in a time of smaller screens and in particular, standard character widths for terminals, something that doesn’t exist anymore, and while I still find short line lengths good for readability, I don’t see much of a difference.

Also, if you actually read PEP8 (https://www.python.org/dev/peps/pep-0008/#maximum-line-length), you’d know that line length is NOT 88, it’s 79. The reason 88 is chosen is because it’s 80 chars + 10%, which is just as arbitrary as using PEP8 + 10% = ~87, or just rounding to 90.

1reaction
knyghtycommented, Dec 8, 2019

I’m not very convinced by your argument. First of all, 88 is quite arbitrary. It’s not really related to PEP8. In fact, the readme says that “90ish” is about right. So why not just make it 90? To directly address your concern: there is no “programming” circumstance for a line length of 88 as opposed to 90.

There is a perfectly logical argument, and that is, why use a number that might make people comfortable when we can be more inclusive (this is a good thing, no?) by simply choosing a less arbitrary (at least in base 10) number such as 90? I don’t see why “emotions” and “logic” have to be separated. I can make many logical arguments for taking people’s emotions into consideration. For example, the community being more welcoming (Python is already extremely good here, relative to other languages and technical communities), which in turn incentivises people to be involved with Python, which means, even in terms of raw numbers, more packages, more committers, more maintainers, etc. And outside of raw numbers, increasing the diversity of the community has the potential to remove programming biases (see this talk from DjangoCon Europe last year: https://pyvideo.org/djangocon-europe-2018/its-not-a-bug-its-a-bias.html).

Moreover, there are two reasons why this seems like an acceptable change to me.

  1. The one thing black does compromise on is line-length, if you are particularly wedded to 88 for some reason, nothing is stopping you.
  2. As black is not quite out of beta, this is a reasonable time to change it. It’s just a default after all, nobody is forcing your lines to be a particular length.

One thing you seem to forget is that different types of feelings are… different. There is a difference between “feeling” python should have a switch statement and “feeling” involuntarily uncomfortable with seeing a certain symbol.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Swastika - Wikipedia
The swastika (卐 or 卍) is an ancient religious and cultural symbol, predominantly in various Eurasian, as well as some African and American...
Read more >
Confederate flags and Nazi swastikas together? That's new ...
That would have surprised Southerners not that long ago. While both the Confederacy and Nazi Germany waged wars to defend white supremacy, those ......
Read more >
Germany Banned Its Ugly Historic Symbols. Should We Do ...
I myself, meanwhile, after innumerable attempts, had laid down a final form; a flag with a red background, a white disk, and a...
Read more >
Hanover superintendent apologizes for controversial logo
HANOVER, Va. (WWBT) - Hanover County Public Schools (HCPS) Superintendent Michael Gill has apologized for a logo that appeared on a shirt ...
Read more >
CPAC Stage Compared To Nazi Symbol On Social Media
Comparisons of law makers to fascists and Nazis isn't uncommon these days, but on Saturday the hashtag #Nazi was trending alongside mentions ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found