[Bug]: "Waiting for target frame x failed" when crawling a lot of websites concurrently

Bug description

Steps to reproduce the problem:

1. Do a lot at the same time (opening a lot of browsers and visiting pages etc.), causing Node to lag.
2. Observe an unhandledRejection like the following:

TimeoutError: Waiting for target frame 38DAB13DFEC9AD09315770D838D9F8C9 failed
    at Timeout._onTimeout (path\to\my_package\node_modules\puppeteer\src\util\DeferredPromise.ts:36:14)
    at listOnTimeout (node:internal/timers:564:17)
    at processTimers (node:internal/timers:507:7)

This is caused by the promise from FrameManager.ts:153 not being fulfilled within 5 seconds (hardcoded in DeferredPromise.ts). If you add if (isRejected) console.log('resolved anyway') to resolve: in DeferredPromise.ts and set process.on('uncaughtException', console.error) then you can see that the promise will be resolved anyway later on.

I think the timeout should probably be configurable in some way (or removed entirely, but it probably serves a purpose).

Puppeteer version

16.2.0

Node.js version

18.7.0

npm version

8.17.0

What operating system are you seeing the problem on?

Windows

Relevant log output

No response

[stevenwdv]

Update: I sometimes have this issue even when I change the timeout to 30 seconds while doing just 5 crawls concurrently, and I can see that the promise would actually be fulfilled eventually.

[OrKoN]

Sorry, looks like a regression slipped in the @jrandolf’s refactoring https://github.com/puppeteer/puppeteer/pull/8863