Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Double ^c not close all browser instances

See original GitHub issue

Steps to reproduce

Puppeteer version: 1.1.1
Platform / OS version: windows
Node.js version: 8.9.4

What steps will reproduce the problem? I use this code :

const puppeteer = require('puppeteer');
var express = require('express');
var app = express();

var browser1 = { browser:{}, page:{}, isFree:true, number:1};
var browser2 = { browser:{}, page:{}, isFree:true, number:2};
var browser3 = { browser:{}, page:{}, isFree:true, number:3};
var browser4 = { browser:{}, page:{}, isFree:true, number:4};
var browser5 = { browser:{}, page:{}, isFree:true, number:5};

app.get('/', async (req, res) => {
  let pdf = await createPDF(req, res);
  if (!pdf){
    res.status(503).send();
  }
  res.status(200).send();
});
app.listen(3000);


let createPDF = async (request, response) => {
  let freeBrowser = await getFreeBrowser(response);
  if (freeBrowser) {
    freeBrowser.isFree = false;
    freeBrowser.browser = await puppeteer.launch({headless: false});
    freeBrowser.page = await freeBrowser.browser.newPage();
}else{
  return false;
}
    let url = request.query.url;
    let JSESSIONID = request.query.JSESSIONID;
    await freeBrowser.page.setCookie({ name: "JSESSIONID", value: JSESSIONID, url: url });
    await freeBrowser.page.goto(url,{waitUntil:'domcontentloaded'});
    await freeBrowser.page.waitForSelector("#ngb-tab-0-panel > grid > div:nth-child(3) > column > make-text > div > span",{'visible':true});
    
    console.log(freeBrowser.number);

    return true;
  }

let getFreeBrowser = (response) => {
  let browser;

  if (browser1.isFree) {
    browser = browser1;
  }
  else if (browser2.isFree) {
    browser = browser2;
  }
  else if (browser3.isFree) {
    browser = browser3;
  }
  else if (browser4.isFree) {
    browser = browser4;
  }
  else if (browser5.isFree) {
    browser = browser5;
  }
  if (browser) {
    return (browser);
  } else {
    return false;
  }
}

What is the expected result? When I shutdown the node server when all browser opend by double ^c not all browser instances closed. Note: When use one ^c all browser instances closed.

What happens instead? All browser instances should closed just like one ^c.

I have a question too, what should happen if the node server closed suddenly ? The browsers now will still opened!