ExecutablePath option ignored

MacOS / BigSur Node 16 (Head) puppeteer-core, 5.5.0

const puppeteer = require('puppeteer-core');
const browser = await puppeteer.launch({
  product: 'chrome',
  headless: false,
  executablePath: '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome'
});

Fails with

Error: Failed to launch the browser process! spawn /usr/bin/chromium-browser ENOENT

As I understand it, it should not be trying to launch chromium at all given the above options and use of puppeteer-core.

[nc]

If however, one modifies the BrowserRunner directly to hardcode the executablePath as shown above, all works as expected. So it seems to be an issue with how the option is being passed to Puppeteer, or how it’s being handled.

class BrowserRunner {
    constructor(executablePath, processArguments, tempDirectory) {
        this.proc = null;
        this.connection = null;
        this._closed = true;
        this._listeners = [];
        this._executablePath = executablePath;
        this._processArguments = processArguments;
        this._tempDirectory = tempDirectory;
    }
    start(options) {
        console.log('>>>>', this._executablePath);
        this._executablePath = '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome';

This prints >>>> /usr/bin/chromium-browser and then proceeds to launch Google Chrome as expected.

[eugene1g]

This happens on Apple Silicon. The path is hardcoded at https://github.com/puppeteer/puppeteer/blob/d901696e0d8901bcb23cf676a5e5ac562f821a0d/src/node/Launcher.ts#L106-L109 introduced in https://github.com/puppeteer/puppeteer/commit/354f9424ae4014e0cd276a930d86a6dae8fe427e

Chromium can run natively on Apple Silicon. Puppeteer does not yet link to that binary, but if the developer uses executablePath to point to another Chrome instance (that might not be compatible with Puppeteer), they already take on those risks and the library should just accept that path.