Implement setDefaultWaitTimeout or setDefaultTimeouts

Right now we have page.setDefaultNavigationTimeout(timeout) which is very useful. If we want to take things forward, we can implement the following,

setDefaultWaitTimeout(timeout)

This will help set a default timeout for waitFor function or similar to those. There are obviously more waitFor use cases than goto.

setDefaultTimeouts({ navigation: timeout, waitFor: timeout })

Same like above, this will let one update all timeouts at once or just the one they want. Will remove the need for setDefaultNavigationTimeout or setDefaultWaitTimeout if happens and window for more useful api

PS: I have a project where I have at least thousands of waitFor cases for some reason and hundreds of navigation calls, this feels really promising in that sense where people have lots of test cases.

[aslushnikov]

We’ve discussed this with @JoelEinbinder and really liked the following approach.

1. For now, let’s keep it simple and introduce a single page.setDefaultTimeout(number) method. This overrides all timeouts we use for navigations and waitFor* methods.

page.setDefaultNavigationTimeout(10000);
// Set all timeouts everywhere for 5 seconds.
// However, the navigation will still default to 10 seconds.
page.setDefaultTimeout(5000);

1. If the need emerges, we can always be fancy and teach page.setDefaultTimeout to accept an object with a set of per-method configuration methods:

page.setDefaultTimeout({
  navigation: 10000, // equal to page.setDefaultNavigationTimeout(1000),
  waitForSelector: 12000, // set default timeout for page.waitForSelector
});

Let me know what you think.

[batpurev]

Hi Gurus,

Have this been implemented? I tried to use this setting but getting this error message.