Intercept Requests Event is Broken

Steps to reproduce

This works in 1.6.2 at least, does not work in any other version I have tried after *1.12, 1.13 etc…

Tell us about your environment:

• Puppeteer version: 1.12 or anything above 1.6.2 it seems
• Platform / OS version: WINDOWS 10
• URLs (if applicable): www.google.com
• Node.js version: latest

What steps will reproduce the problem? Enable Intercept Request Load page all resources are now pending.

Please include code that reproduces the issue.

 const browser = await launch({
    headless: false,
    args: [
      // `--proxy-server=${ROUTER_PROXY}`,
      "--no-sandbox",
      "--disable-setuid-sandbox",
      "--disable-dev-shm-usage",
      "--disable-accelerated-2d-canvas",
      "--disable-gpu",
      "--window-size=1920x1080",
      "--enable-feature=NetworkService"
    ]
  });

private interceptRequest = async (request: puppeteer.Request) => {
    console.warn("INTERCEPTED");
    await request.continue();
    return;
}

 const page = await browser.newPage();
      page.on("request", this.interceptRequest);

      this.page = page;
      await page.setViewport({ width: 1920, height: 1080 });
      await page.setUserAgent(this.agent);
      await page.setRequestInterception(true);
      page.on("response", this.interceptResponse);
      this.logger("Request Interception On");

      await page.goto("http://www.google.com");

What is the expected result? For the page to load correctly

What happens instead? Currently it loads the page without any other asset (images, fonts )

[Morphexe]

@aslushnikov So I found out its a scoping issue, the “this” is being rebinded by puppeter or something else on its inner workings. Thats why it wasn’t working, although I am not sure why the requests were being hanged even with that. But I figured it out by using lambdas, so should be fine for now.

What threw me off was that the old version was working perfectly, I was looking at examples and it was the same thing as before, so I couldn’t figure out what was running through on this.

[aslushnikov]

@Morphexe the following works just fine for me on v1.13.0:

const puppeteer = require('puppeteer');

async function main() {
    const browser = await puppeteer.launch({headless: false})
    const page = await browser.newPage()
    await page.setRequestInterception(true);
    page.on('request', request => {
      console.log('INTERCEPTED: ' + request.url());
      request.continue();
    });
    await page.goto('https://google.com');
}
main()