page.evaluate hangs on Args key has unicode char

Steps to reproduce

Calling await page.evaluate() hangs on Args key has unicode char Tell us about your environment:

• Puppeteer version: 1.16.0
• Platform / OS version: windows10 1809
• URLs (if applicable):
• Node.js version: 8.16.0

What steps will reproduce the problem?

const puppeteer = require("puppeteer");

(async () => {
    const browser = await puppeteer.launch()
    try {
        const page = await browser.newPage();
        console.log("wait evaluate");
        await page.evaluate(() => { }, {"中文字符": 1 })
    } finally {
        browser.close();
    }
})()

What is the expected result? await page.evaluate(() => { }, {"中文字符": 1 }) should resolve quickly !

What happens instead? Script hangs on line 8

[powdercloud]

I think it’s because v8 hasn’t rolled into Chromium yet, so if you just checkout Chromium it won’t have the fix for v8. However, you can checkout Chromium, change into it’s src/v8, and in there, checkout master, run git pull - building headless_shell with that should do the trick. Thanks a lot for adding a puppeteer test. I’ll play with it on Monday (by then, v8 inside Chromium should be up to date).

[powdercloud]

I have a fix for it. Will need to roll it into Chromium / V8. https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1618460