page.goto returns null periodically

Steps to reproduce

Similar/same as: #1391

Tell us about your environment:

• Puppeteer version: 1.3.0
• Platform / OS version: Mac
• URLs (if applicable): https://www.microsoft.com/en-gb/store/d/xbox-one-s-1tb-console-playerunknowns-battlegrounds-bundle/908z9jn5cnh2/gz4w?cid=msft_web_collection
• Node.js version: 9.11.1

What steps will reproduce the problem?

const browser = await puppeteer.launch();

const page = await browser.newPage();

for (var i = 0; i < 15; i++) {
  const r = await page.goto('https://www.microsoft.com/en-gb/store/d/xbox-one-s-1tb-console-playerunknowns-battlegrounds-bundle/908z9jn5cnh2/gz4w?cid=msft_web_collection', { waitUntil: 'domcontentloaded' });

  console.log(r.ok());
}

await browser.close();

What is the expected result?

true outputted 15 times

What happens instead?

Sometimes true 15 times, sometimes TypeError: Cannot read property 'ok' of null

It works as expected on 1.2.0, but fails on 1.3.0

[bluepeter]

Here’s a bit of a workaround until this is fixed:

let fullResponse = await chromePage.goto("https://wherever.com");
if (fullResponse === null) {
  console.log("Got null, trying wait.");
  fullResponse = await chromePage.waitForResponse(() => true);
}

[Schaka]

if (response === null) {
    response = await page.waitForResponse(() => true);
}

This will return the first response you’re getting once interception starts. This will NOT return the intial request you’re actually looking. So if you actually need that request, you’re out of luck unless you use an incognito tab.