page.on('request') doesn't take header overrides into account when processing redirects (301/302)

Steps to reproduce

Tell us about your environment:

• Puppeteer version: 0.13
• Platform / OS version: any
• URLs (if applicable): https://try-puppeteer.appspot.com/

What steps will reproduce the problem?

const browser = await puppeteer.launch();

const page = await browser.newPage();
await page.setRequestInterception(true);
page.on('response', (response) => {
  console.log('RESPONSE RECEIVED');
  console.log(response.status + ' ' + response.url);
});
page.on('request', (request) => {
 console.log('REQUEST RECEIVED');
  console.log(request.url);

  request.continue({headers: {'test-header': 'dummy-value'}});
});

await page.goto('http://www.mocky.io/v2/5a427066300000821d709e0f');
//await page.goto('https://www.whatismybrowser.com/detect/what-http-headers-is-my-browser-sending');

await page.screenshot({path: 'screenshot.png', fullPage: true});

await browser.close();

I’ve included the following minimal puppeteer code and 2 sample urls. https://www.whatismybrowser.com/detect/what-http-headers-is-my-browser-sending which is a basic page that returns the HTTP headers sent in the request. And http://www.mocky.io/v2/5a427066300000821d709e0f which returns a 302 to the url specified above.

What is the expected result? Puppeteer should send my custom header in both cases.

What happens instead? Puppeteer doesn’t send the custom header in the request that follows the 301/302. Even though the onRequest event is fired for both the 301 request and the followup request.

[Glennvd]

FYI this has been fixed in the latest master chromium builds when using --enable-features=NetworkService, in case this is a blocking issue for anyone else.

[aslushnikov]

Thanks @Glennvd @yujiosaka for the investigation!