Puppeteer ignoring lang arg to launch

Steps to reproduce

Tell us about your environment:

• Puppeteer version: 3.10
• Platform / OS version: OSX 10.14.6
• URLs (if applicable):
• Node.js version: 10.9.0

What steps will reproduce the problem?

1. npm install puppeteer
2. run the following code:

const puppeteer = require("puppeteer");

(async function() {
  const u = "https://www.google.com/search?q=foo"
  const browser = await puppeteer.launch({
    headless: false,
    args: ['--lang="en-US"'],
  });
  page = await browser.newPage();
  await page.goto(u);
})();

1. I am in Israel the results are in Hebrew and sometimes German oddly enough.
2. When I launch my local chromium like this: $ node_modules/puppeteer/.local-chromium/mac-756035/chrome-mac/Chromium.app/Contents/MacOS/Chromium --lang="en-US" and search for “foo” my results are in English.

What is the expected result? Chromium should be launched in the language specified by the lang arg.

What happens instead? Chromium seems to launch in the language of my location and ignores the lang arg to launch.

[davidjgoss]

Per this comment https://bugs.chromium.org/p/chromium/issues/detail?id=755338#c14 seems this isn’t really supposed to work and we should be using the LANG environment variable instead.

h/t @dom54

[UInIQ]

@davidjgoss Speaking as someone who just spent FAR longer than he’d like to have beating his head against this particular wall, I wanted to, with all the grateful sincerity I can muster, compliment you on your anal-retentive attention to detail, both in finding that little nugget, and then remembering to come back here and post the update some three months after the initial question was posted and some two months after the most recent activity.

Wow, man. I can barely remember what I had for lunch on Sunday. My (evident) mnemonic shortcomings aside, though, honestly: thanks for taking the time. You just saved me a much larger headache than I’d already built up. You’re appreciated. ❤️