While generating pdf, landscape option doesn't work

Steps to reproduce

Tell us about your environment: We are trying to generate pdf using puppeteer. Previously we had the landscape option working on Puppeteer 1.5.0 and node 8.9.4. But, after we moved around the code and updated the node and puppeteer versions to 8.15.0 and 1.11.1 respectively, the landscape option tends to generate a portrait instead of a landscape.

• Puppeteer version: 1.11.1
• Platform / OS version: ubuntu
• URLs (if applicable):
• Node.js version: 8.15.0

Please include code that reproduces the issue.

function generatePDF(html, options) { // options has landscape param set to true or false browser = await puppeteer.launch({ args: this.puppeteerArgs }); page = await browser.newPage(); const session = await page.target().createCDPSession();

  await session.send('DOM.enable');
  await session.send('CSS.enable');
  await page.goto(`data:text/html,${html}`, { waitUntil: 'networkidle2' });

  this.logger.debug('generatePDF - creating pdf buffer..');
  const buffer = await page.pdf(options);
  await page.close();
  await browser.close();
  return buffer;

} What is the expected result? generates a landscape view

What happens instead? generates a portrait view

[toix]

Have you tried altering the CSS rule @page?

@page {
    size: auto;
}

Edit: You can use the CSS rule only for Puppeteer:

page.addStyleTag(
    {'content': '@page {size: auto}'}
)

[JandosKh]

I’m using PuppeteerSharp v1.20.0. I confirm that landscape option doesn’t work. Explicitly setting page width & height didn’t work also. However, using page.addStyleTag worked for me. You can try page.addStyleTag( {‘content’: ‘@page { size: A4 landscape; }’} )