Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

consistent air temperature naming

See original GitHub issue

A lot of pvlib uses the term temp_air for ~2 m air temperature. The get_solarposition function (perhaps among others) uses temperature, which causes some confusion (see https://github.com/pvlib/pvlib-python/pull/893#issuecomment-587052032). We should standardize the naming.

My vote is temperature. I really dislike temp_air.

Note that MetPy recently went through a similar parameter name refactoring and chose temperature (among other things): https://github.com/Unidata/MetPy/pull/1299

Issue Analytics

State:
Created 4 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

2reactions

cwhansecommented, Feb 24, 2020

I think it would help to compile a glossary of what’s currently used in the API, by topic. I can take a crack at that.

1reaction

cwhansecommented, Feb 17, 2020

I can accede to temperature for ambient temperature for compatibility with metpy and I’m OK with dew_point. We should also agree on names for the other temperature quantities: cell temperature (currently temp_cell in functions, cell_temperature attribute of ModelChain), module temperature (unnamed), (future) inverter temperature (unnamed). Do we distinguish between dry-bulb and wet-bulb air temperatures?