Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

irradiance.detect_clearsky: possibly redundant input 'times'

See original GitHub issue

irradiance.detect_clearsky expects measured and clear-sky GHI to be input as Series, and has an input times as a DatetimeIndex. https://github.com/pvlib/pvlib-python/blob/85eeaa795e82bb486bc58488ac70269da8c72be0/pvlib/clearsky.py#L629

What is the use case for having times as a separate input? Should the function instead use measured.index?

Issue Analytics

State:
Created 3 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

wholmgrencommented, May 7, 2021

Fine with me to keep it open in an effort to simplify API or to close in an effort to clean the issues board. Either way not going into 0.9, so I removed the milestone.

0reactions

cwhansecommented, May 7, 2021

#1074 changed times from an arg to a kwarg with default None. Both measured and clearsky arguments can still be array. I think it does no harm to keep times for compatibility with any legacy code.

Recommend closing this issue.

Top Results From Across the Web

Clear sky — pvlib python 0.9.0+0.g518cc35.dirty documentation

An iterative algorithm identifies clear periods, uses the identified periods to estimate bias in the clearsky data, scales the clearsky data and repeats....

Clear-sky irradiance predictions for solar resource mapping ...

Clear-sky irradiance predictions for solar resource mapping and large-scale applications: Improved validation methodology and detailed performance analysis ...

Field measurement of clear-sky solar irradiance in Badain ...

specification of input parameters and better measure- ments of irradiances. Wang et al. [14] also achieved an excellent clear-sky shortwave ...

Validation of models that estimate the clear sky global and ...

... A clear-sky model estimates the solar irradiance that reaches the ground surface when the sky is clear without clouds. Such models were ......

Statistical Criteria for Characterizing Irradiance Time Series

Time series of irradiance are used in analyses that seek to quantify the ... analysis, the analysis inputs representing the solar resource should...