pvlib.solarposition.spa_python has unused and undocumented **kwargs

pvlib.solarposition.spa_python has **kwargs in the signature, but it doesn’t mention it in the docstring, and it doesn’t do anything with it in the function body.

https://github.com/pvlib/pvlib-python/blob/c2431832040f585969bbd1868f6acdd6ddb4e0a5/pvlib/solarposition.py#L276-L278

This is bad because it silently ignores misspelled optional parameters, for example: pvlib.solarposition.spa_python(times, 40, -80, atlitude=100).

---

We could just deprecate and remove **kwargs like #1053:

https://github.com/pvlib/pvlib-python/blob/a6667a390d048d4301f73acef3267596dc1fafcd/pvlib/location.py#L83-L87

Or we could keep **kwargs and pass them through to spa.solar_position(), thereby exposing the sst and esd parameters. Though if we want to expose those, I’d prefer just exposing them directly instead of hiding them in **kwargs.

This could be a good “easy first issue” once we decide what the fix should be.

[wholmgren]

I’d support removing without deprecation. Only impact on users will be to reveal bugs in their code.

[cwhanse]

I agree, no reason that any solar position function needs turbidity. What do you think about handling the **kwargs in pvlib.solarposition.get_solarposition instead of in the Location methods?