question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

reevaluate numba minimum, usage patterns in spa.py

See original GitHub issue

conda search -c main numba | grep py36 shows that numba 0.36.1 is the oldest package compatible with python 3.6 and numpy 1.12. The numba git history says 0.36.1 was released on Dec 7, 2017. (0.17.0 was released Feb 3, 2015.) I’ll add that to the asv conf.

I’d be fine with also adding a minimum numba requirement to setup.py, but I think that should be done in combination with changes to the import logic in spa.py. In particular, I don’t like the numpy fallback - that led to hard to track down errors when developing this. It would also be worth reviewing modern numba best practices. If we’re adding a minimum numba requirement to setup.py then we should probably be testing against it too. More than I want to tackle in this PR.

_Originally posted by @wholmgren in https://github.com/pvlib/pvlib-python/pull/1059#discussion_r488775560_

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
wholmgrencommented, Nov 18, 2020

I’m fine with giving up call-by-call numba control. We could also give up PVLIB_USE_NUMBA and instead point users to NUMBA_DISABLE_JIT. Situations in which a user wants numba for one library but not another are probably pretty rare, so I’m skeptical that it’s worth our time to code around that.

1reaction
wholmgrencommented, Nov 26, 2020

I was thinking we’d rely on different ci configurations for total coverage. The coverage within a single configuration would be incomplete. So I don’t think we’d need any special import or environment machinery.

Read more comments on GitHub >

github_iconTop Results From Across the Web

A ~5 minute guide to Numba — Numba 0.50.1 documentation
A ~5 minute guide to Numba¶. Numba is a just-in-time compiler for Python that works best on code that uses NumPy arrays and...
Read more >
Tutorial: Create a JavaScript single-page application that uses ...
In this tutorial, you build a JavaScript single-page application (SPA) that uses the Microsoft identity platform to sign in users and get an ......
Read more >
11 JWT Token Security Best Practices | Curity
Best practices for using JTWs in applications. Learn about JWTs as access tokens, which algorithms to use, when to validate the token and...
Read more >
High-performing Apps With Python: A FastAPI Tutorial - Toptal
Great frameworks even make the whole development experience enjoyable. FastAPI is a new Python web framework that's powerful and enjoyable to use. The...
Read more >
Web Scraping with Python: Everything you need to know (2022)
HyperText Transfer Protocol (HTTP) uses a client/server model. An HTTP client (a browser, your Python program, cURL, libraries such as ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found