Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Not compatible with Black

See original GitHub issue

According to official link, I am using the following pre-commit-config:

repos:
  - repo: https://github.com/PyCQA/isort
    rev: 5.10.1
    hooks:
      - id: isort
        args: ["--profile", "black", "--filter-files"]
  - repo: https://github.com/psf/black
    rev: 22.6.0
    hooks:
    -   id: black

However, for this file, isort’s output is

from ..builder import (DETECTORS, build_backbone, build_head, build_map_to_bev,
                       build_neck, build_segmentor, build_voxel_encoder,)

while Black’s output is:

from ..builder import (
    DETECTORS,
    build_backbone,
    build_head,
    build_map_to_bev,
    build_neck,
    build_segmentor,
    build_voxel_encoder,
)

Different output, so the pre-commit check would never pass.

Issue Analytics

State:
Created a year ago
Reactions:3
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

zheyuanWangcommented, Dec 13, 2022

@zheyuanWang should be fixed in 5.11.0, can you check?

Yes it worked!

changing the version of isort solved conflicts.

repos:
  - repo: https://github.com/PyCQA/isort
    rev: 5.11.0
    hooks:
      - id: isort
        args: ["--profile", "black", "--filter-files"]
  - repo: https://github.com/psf/black
    rev: 22.6.0
    hooks:
    -   id: black

1reaction

staticdevcommented, Dec 12, 2022

@zheyuanWang should be fixed in 5.11.0, can you check?