paths.py - replacing space with slash+space

Hi!

First of all, thanks for the library. Very useful! Second, I wanted to ask you why do you replace space with slash+space in paths.py? Is this a bug or something you’ve done on purpose?

imagePath = os.path.join(rootDir, filename).replace(" ", "\\ ")

PS: I’m using Windows and Python3.

[jrosebr1]

It’s not a bug. It’s to escape file paths that have spaces in them. If you’re on a Unix machine try to auto-tab complete a file path that has spaces in them.

It will change:

$ cd Foo Bar

To:

$ cd Foo\ Bar

[skypanther]

There’s no reason to manually add the slash in there with that replace operation. os.path handles that for you automatically. For example, this works fine (assuming the directory and file exist):

import os

file_path = os.path.join('.', 'folder name with spaces', 'somefile.txt')

if not os.path.isfile(file_path):
    raise ValueError(f'Cannot read file at {file_path}')
with open(file_path) as f:
    print(f.read())

results in

≫ python file_test.py
this is some file

I don’t have a Windows computer to test that on, but according to the docs it should be fine. If you were targeting only python 3.4+ you could use the pathlib module instead.