JSONDecodeError exception is raised

Bug description

Upon following the README.md to install, successfully running given the examples within python projects. When I run outside of a python project; I get an error on a windows system. It’s needlessly verbose.

This isn’t just about me testing the fences or being obtuse. Sometimes CI and build servers (particularly in mono-repos) need to switch environments and working directories. This would absolutely impact the case for a windows runner in the wrong folder.

Reproduction steps

python3 -m pip install -U pip-audit
pip-audit

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots and logs

$ pip-audit
WARNING: You are using pip version 20.3.1; however, version 21.3.1 is available.
You should consider upgrading via the 'c:\python38amd64\python.exe -m pip install --upgrade pip' command.

←[?25hTraceback (most recent call last):
  File "c:\python38amd64\lib\site-packages\pip_audit\_dependency_source\pip.py", line 64, in collect
    for (_, dist) in pip_api.installed_distributions(local=self._local).items():
  File "c:\python38amd64\lib\site-packages\pip_api\_installed_distributions.py", line 83, in installed_distributions
    return _new_installed_distributions(local)
  File "c:\python38amd64\lib\site-packages\pip_api\_installed_distributions.py", line 71, in _new_installed_distributions
    for raw_dist in json.loads(result):
  File "c:\python38amd64\lib\json\__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "c:\python38amd64\lib\json\decoder.py", line 340, in decode
    raise JSONDecodeError("Extra data", s, end)
json.decoder.JSONDecodeError: Extra data: line 2 column 1 (char 30318)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "c:\python38amd64\lib\runpy.py", line 193, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\python38amd64\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Python38amd64\Scripts\pip-audit.exe\__main__.py", line 7, in <module>
  File "c:\python38amd64\lib\site-packages\pip_audit\_cli.py", line 240, in audit
    for (spec, vulns) in auditor.audit(source):
  File "c:\python38amd64\lib\site-packages\pip_audit\_audit.py", line 60, in audit
    yield from self._service.query_all(specs)
  File "c:\python38amd64\lib\site-packages\pip_audit\_service\interface.py", line 115, in query_all
    for spec in specs:
  File "c:\python38amd64\lib\site-packages\pip_audit\_dependency_source\pip.py", line 81, in collect
    raise PipSourceError("failed to list installed distributions") from e
pip_audit._dependency_source.pip.PipSourceError: failed to list installed distributions

Platform information

• OS name and version: Windows 10 64-bit Pro
• pip-audit version (pip-audit -V): 1.0.0
• Python version (python -V or python3 -V): 3.8.1 😬 (I’ll upgrade that separately)
• pip version (pip -V or pip3 -V): 21.1.2

Additional context

I Understand I should perhaps use flags.

I expected this to be the default, or for usage to be output if I supply no default command.

• pip-audit -l works
• pip-audit --help works
• pip-audit -r /path/to/requirements.txt works for both existing and non-existing paths

[Lewiscowles1986]

TBF, I will just avoid using this on windows. That is my fix for myself 😄

[woodruffw]

Hmm, that JSONDecoderError is fishy — looks similar to #116, which we never fully root caused.

Sent from mobile. Please excuse my brevity.

On Dec 1, 2021, at 10:46 PM, Lewis Cowles @.***> wrote:

The working directory should not matter for pip-audit -l or in-fact pip-audit (no arguments) in my opinion. That is not the subject of this issue. Operating from a different folder generates the same issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.