question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Change imports to a one-per-line style

See original GitHub issue

This would prevent useless merge conflicts.

I think it would only need to add force_single_line = true to our isort configuration.

_Originally posted by @pradyunsg in https://github.com/pypa/pip/pull/6729#issuecomment-513418090_

And for the record, I’m in favor 😃

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:3
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
pfmoorecommented, Jul 24, 2019

Good point re reducing the pain for external contributors. I’ll learn to live with the change, might even persuade me to improve my workflow, who knows? 😃

1reaction
pradyunsgcommented, Jul 22, 2019

FWIW, we’d probably use a style like:

from pip._internal.utils.misc import (
    _make_build_dir,
    ask_path_exists,
    backup_dir,
    call_subprocess,
    display_path,
    dist_in_site_packages,
    dist_in_usersite,
    ensure_dir,
    get_installed_version,
    redact_password_from_url,
    rmtree,
)

I’m almost certain that isort supports this as a mode in it – 3 or 5.

(I typed this on Monday morning, on my mobile, while walking to class. I’m weird.)

I see there was some discussion at #6729 so I figured it’d help to clarify.

/cc @pfmoore

Read more comments on GitHub >

github_iconTop Results From Across the Web

One Import Per Line Preference - PyCharm Guide - JetBrains
PyCharm's Optimize Imports acts as your import janitor and it has settings which let you specify some options on style import.
Read more >
Configuration of one-per-line import splitting? #204 - GitHub
Imports will be updated to be one per line. Not everyone wants this as it takes up vertical screen space adds more scrolling....
Read more >
Managing Import Profiles - Ex Libris Knowledge Center
Create an import profile: See Creating an Import Profile: Profile Type. Edit an import profile - Select Edit from the row actions list....
Read more >
How do I change imported line styles with Ideate Software tools?
A recent customer request came into our queue about the ability of Ideate StyleManager to modify the color property of a CAD Import...
Read more >
git-fast-import Documentation - Git
Specify the type of dates the frontend will supply to fast-import within author , committer and tagger ... Marks are written one per...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found