Pip install from internal pypi server containing git links fails with pypi 19.1

Environment

• pip version: 19.1
• Python version: Python 3.6.7
• OS: Ubuntu 18.04

Description We have pypi server that contains links to git:

git+ssh://<url>.git@0.1.0.201810251140#egg=<package>-0.1.0.201810251140

pip install <package> fails with

  GitLab: The project you were looking for could not be found.
  fatal: Could not read from remote repository.

  Please make sure you have the correct access rights
  and the repository exists.

Expected behavior pip install <package> has been working and does work if I install pip<19.1

How to Reproduce

To reproduce this one needs local pypi server.

Add git+ssh://<url>.git@0.1.0.201810251140#egg=<package>-0.1.0.201810251140 style link to pypi server where that version number is a git tag.

Then:

virtualenv --python python3 env
. env/bin/activate
pip install 'pip==19.1'
pip install -vvv <package>

Output:

git clone -q ssh://<url>.git%400.1.0.201810251140 <temp>

Running same with pip<19.1 outputs

git clone -q ssh://<local_path>.git <temp>

It looks like the problem is that %400.1.0.201810251140 left in the git link.

[cjerdonek]

Yes, I think so.

[nicolasbock]

@cwharland Could you create a separate issue? It sounds like it is also caused by #6245 but it’s different than the issue with git+ssh URLs. Thanks!