Some unit tests are sensitive to Timezone of host machine

Description

Running the pip unit tests on Windows in (UTC-5:00) Eastern (US & Canada):

1. nox -s test-3.7 – -m unit --verbose --numprocesses auto --showlocals

I get a handful of FAILEDs, however if I change the hosts timezone to UTC I get 5 less FAILEDs, specifically this set of tests:

FAILED tests/unit/test_base_command.py::test_log_file_command_error - assert False
FAILED tests/unit/test_base_command.py::test_log_command_error - assert False
FAILED tests/unit/test_base_command.py::test_log_command_success - AssertionError: assert '2019-01-17T01:00:37,040 fake' == '2019-01-17T06:00:37,040 fake'
FAILED tests/unit/test_logging.py::TestIndentingFormatter::test_format_with_timestamp[INFO-2019-01-17T06:00:37,040 hello\n2019-01-17T06:00:37,040 world] - As...
FAILED tests/unit/test_logging.py::TestIndentingFormatter::test_format_with_timestamp[WARNING-2019-01-17T06:00:37,040 WARNING: hello\n2019-01-17T06:00:37,040 world]

Expected behavior

Shouldn’t need to change timezone to run pip tests locally?

pip version

22

Python version

3.7.9

OS

Windows 10

How to Reproduce

Above

Output

No response

Code of Conduct

• I agree to follow the PSF Code of Conduct.

[notatallshaw]

Unless someone else is very motivated to fix these I’m happy to try and make a PR this weekend, give me a chance to learn a bit more about tests. I’ll update back here with my progress if I run in to an issue I can’t fix.

[uranusjr]

Python 3.10.0 (tags/v3.10.0:b494f59, Oct  4 2021, 19:00:18) [MSC v.1929 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import datetime
>>> now = datetime.datetime.now()
>>> print(now)
2022-01-31 14:37:10.435059
>>> local_now = now.astimezone()
>>> print(local_now)
2022-01-31 14:37:10.435059+08:00
>>> local_tz = local_now.tzinfo
>>> print(local_tz)
Taipei Standard Time
>>> local_tzname = local_tz.tzname(local_now)
>>> print(local_tzname)
Taipei Standard Time
>>>