'--completion' should take an argument on which shell to eval for
See original GitHub issueExpected result
pipenv
should be usable with direnv
, i.e. like minikube
does:
eval "$(minikube docker-env --shell bash)"
the shell
parameter exactly does what i would expect for pipenv
.
Actual result
internally, direnv
uses bash
spawn to do it’s work, and will pass the changes to the actual shell.
therefore, using direnv
in conjunction with fish
shell will always detect fish
as shell.
as the syntax is not compatible, this will fail.
Steps to replicate
- use
direnv
- have
eval "$(pipenv --completion)"
in.envrc
- issue
direnv allow
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (3 by maintainers)
Top Results From Across the Web
What is the "eval" command in bash? - Unix Stack Exchange
It will take an argument and construct a command of it, which will then be executed by the shell. This is the example...
Read more >Bash eval command - Linux Hint
Here, arguments are parsed and combined into a string that will execute by the shell. `eval` returns an exit status code after executing...
Read more >The 'eval' command in Bash and its typical uses - Stack Overflow
eval takes a string as its argument, and evaluates it as if you'd typed that string on a command line. (If you pass...
Read more >Adding arguments and options to your Bash scripts - Red Hat
The ability to use positional parameters—otherwise known as arguments—to specify data to be used as values for variables in the scripts is one ......
Read more >Shell Completion — Click Documentation (7.x)
Generally, the shell completion support will complete commands, options, and any option or argument values where the type is click.Choice .
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
#1762
@gretel if you open an issue that is an exact duplicate of an issue which has already been opened, has a full discussion etc, then the expectation is that you can read that one for resolution. This is pretty common for github issue triage.
As you can see we handle issues in the thousands but are not many people. If you can’t even read the ‘lengthy discussion’ about how to use pipenv with
direnv
, why it’s not built in, and other things that have already been hashed out, why should we spend our (incredibly limited, btw) time giving you a full response?If you want to re-post the same topic we have already decided on, you need to tell us why your issue is different and demonstrate that you’ve read the original discussion. Right now you’re just demanding a fix. We literally had this exact discussion. Is the problem that we didn’t resolve it to your liking? If so, uh, sorry.