pipenv does not install gitlint

gitlint is not installed when using --dev --deploy flags.

Here’s my Pipfile:

[[source]]

url = "https://pypi.python.org/simple"
verify_ssl = true


[requires]

python_version = '3.6'


[dev-packages]

django-debug-toolbar = "*"
"pep8-naming" = "*"
"flake8-builtins" = "*"
"flake8-commas" = "*"
"flake8-quotes" = "*"
"flake8-blind-except" = "*"
"flake8-bugbear" = "*"
"flake8-comprehensions" = "*"
"flake8-pep3101" = "*"
pytest = "*"
"pytest-flake8" = "*"
pytest-isort = "*"
pytest-django = "*"
pytest-cov = "*"
gitlint = "*"
pre-commit = "*"
xenon = "*"
radon = "*"
pylint = "*"
pytest-xdist = "*"


[packages]

django = "<1.12"
django-split-settings = "*"
django-axes = "*"
"psycopg2" = "*"
gunicorn = "*"
unipath = "*"
python-decouple = "*"
djangorestframework = "*"
djangorestframework-jwt = "*"

Here’s the command I am using: pipenv install --dev --deploy. The same happens with just --dev.

It was working some versions ago.

Describe your environment

1. OS Type: macos
2. Python version: Python 3.6.2
3. Pipenv version: pipenv, version 8.3.1

Expected result

I expect every dependency from Pipfile to be installed.

Actual result

Here’s my pip freeze:

» pip freeze
apipkg==1.4
aspy.yaml==1.0.0
astroid==1.5.3
attrs==17.2.0
cached-property==1.3.1
certifi==2017.7.27.1
chardet==3.0.4
colorama==0.3.9
coverage==4.4.1
Django==1.11.7
django-axes==2.3.3
django-debug-toolbar==1.8
django-split-settings==0.2.5
djangorestframework==3.7.1
djangorestframework-jwt==1.11.0
execnet==1.5.0
flake8==3.5.0
flake8-blind-except==0.1.1
flake8-bugbear==17.4.0
flake8-builtins==1.0
flake8-commas==0.4.3
flake8-comprehensions==1.4.1
flake8-pep3101==1.1
flake8-polyfill==1.0.1
flake8-quotes==0.12.0
gunicorn==19.7.1
identify==1.0.6
idna==2.6
isort==4.2.15
lazy-object-proxy==1.3.1
mando==0.6.4
mccabe==0.6.1
nodeenv==1.2.0
pep8-naming==0.4.1
pre-commit==1.3.0
psycopg2==2.7.3.2
py==1.4.34
pycodestyle==2.3.1
pyflakes==1.6.0
PyJWT==1.5.3
pylint==1.7.4
pytest==3.2.3
pytest-cache==1.0
pytest-cov==2.5.1
pytest-django==3.1.2
pytest-flake8==0.9.1
pytest-forked==0.2
pytest-isort==0.1.0
pytest-xdist==1.20.1
python-decouple==3.1
pytz==2017.3
PyYAML==3.12
radon==2.1.1
requests==2.18.4
six==1.11.0
sqlparse==0.2.4
Unipath==1.1
urllib3==1.22
virtualenv==15.1.0
wrapt==1.10.11
xenon==0.5.4

Steps to replicate

1. Copy Pipfile
2. pipenv install --dev
3. Check for gitlint in pip freeze and Pipfile.lock

[techalchemy]

@sobolevn I said I would strongly caution, I didn’t say it was always wrong! If you want them to fail if hashes don’t match, and to use dev dependencies, then passing --dev and --deploy is correct

Also I was only able to turn it around this quickly because

1. @nateprewitt found the exact commit where I introduced the bug so I can pinpoint exactly what caused it (I didn’t get that far this morning);
2. I’ve spent tens of hours digging through requirements parsing code libraries in pip, pip-tools, pkg_resources, setuptools, requirements, packaging, etc in the last few weeks fixing local file install related issues so I had the solution fresh at hand
3. Last time I looked at this particular bit of code I was kind of suspicious about it, a bit skeptical that it wouldn’t cause any issues because of how it parses keys and values the same way, but I wasn’t working on VCS dependencies so I wasn’t prepared to touch it then

So honestly, the quick fix was basically just luck on my end.

[sobolevn]

This happens again with pipenv==9.0.0.

@techalchemy do you know how we can fix it?