`pipenv shell` with fish shell requires entering a command to complete

I have a small quirk when running pipenv shell with fish shell. When I run it, env var get loaded, and a subshell is spawned, but then it left me with a prompt, with a prepared activation command in it, the cursor at the end of the line, and I have to press enter again to activate the env.

~/path/of/work/dir > pipenv shell
Loading .env environment variables…
Spawning environment shell (/usr/bin/fish). Use 'exit' to leave.
~/path/of/work/dir > source /home/my-name/.local/share/virtualenvs/my-env-name/bin/activate.fish [cursor here and command ready to run]
# press enter
(name-of-my-env)   ~/path/of/work/dir >

I expect pipenv shell to work in one go, just as it does in bash. It’s not a blocking problem, it just feels broken. And it prevents from automating too.

os: linux mint 18 cinnamon 64-bit
related ubuntu repo: Xenial 16.04
terminal emulator: terminator 0.98-1
fish: 2.7.1-1~xenial
Python: 3.6.5
pipenv: 2018.5.18

[uranusjr]

Sounds like a Fish-specific quirk… or is it environment-specific? I don’t use Fish at all and will need someone to verify.

In the mean time, does pipenv shell --fancy work for you? We (well, I) want to push its adoption if it does. The fancy alternative is so much less hacky than the default implementation.

[zanchey]

(hello, I’m one of the fish committers)

I can’t reproduce the originally-described problem (the source line is left in the command buffer, awaiting the enter key) here on macOS with pipenv, version 2018.11.26 and fish 3.0.0.

My guess with the problems with $PATH is that you are changing the path variable in your config.fish, and perhaps those lines should be guarded by if status is-login or similar.