Remove easter eggs
See original GitHub issueI just noticed the tweet https://twitter.com/KumarVimal/status/1057149022346137600 . Apparently pipenv has an easter egg that shows a pumpkin around Halloween, see https://github.com/pypa/pipenv/blob/d069dff844c04babe4827eb33e443c180e83c5bb/pipenv/core.py#L73-L93 . I’m really worried about this.
I’m aware that some people find easter eggs an amusing gimmick in software. However easter-eggs make software unpredictable and are a even potential security. This is especially true for easter eggs that are triggered by default. CPython has some easter eggs like import this
, however they are never triggered either time, environment, or default. Pipenv strives to become a defacto tool for Python’s packaging infrastructure. Please be more responsible and serious.
Bugs like Gimme Gimme Gimme have been caused by easter eggs.
Issue Analytics
- State:
- Created 5 years ago
- Reactions:14
- Comments:8 (2 by maintainers)
Top GitHub Comments
The easter eggs stay.
@kennethreitz That’s one way to kill a discussion. Not necessarily a polite way, though.