Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Add unit tests for _download_url?
See original GitHub issueCurrently _download_git, _download_svn and _download_hg are all not getting hit by the test suite.
It will probably be useful to add unit tests that hit (via the public interface) those code paths.
I think the easiest way to get a useful version of this working is to mock out os.system and check that the correct system calls are made.
We can and possibly should also make integration tests that actually make the relevant system calls, but we can defer those later because they have some more dev-ops-y implications.
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (6 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@jaraco I think we should do the basic smoke tests (i.e. mock out the system calls), if only so that the CI won’t complain about coverage issues when we make changes like #1499.
Also, when we do “hard” deprecate them, we’ll want tests to make sure the deprecation warnings are raised, and having some existing “mock tests” will make that easier (since we can just inject the “pytest.warns” assertion directly into those tests).
working on this with @vitoace and @serjx86