Git and Mercurial revision checkout not working under Windows

The revision checkout routines located in setuptools/setuptools/package_index.py, functions _download_git and _download_hg, rely on (cd %s && <command>) to execute <command> in %s. This does not work under Windows, as simply tested by executing cd .. && echo %cd%.

Further reading: https://stackoverflow.com/q/55641332

[benoit-pierre]

@jaraco: well, using git -C is cleaner, although the code still suffer from some of the same issues (no escaping of arguments for example). I don’t think there’s a point in spending more time investigating the issue when most of this code is deprecated by the use of pip.

@2xB: the unfortunate truth is direct URL requirements are a very poor replacement for dependency links. In fact, I think there’s pretty much useless, see discussion here: https://github.com/pypa/pip/issues/5898.

In your case, I would change the requirement to pyqtgraph==0.11.0.dev0+g7201bae, forget about dependency links or using a direct URL requirement, and then either maintain a custom index if your creating private packages or make the wheel / source distribution available at a public URL so you can ask users to install using pip install -f public_url_for_patched_pyqtgraph_version mypackage. There’s no way to get pip to install the custom version with a simple pip install mypackage invocation.

[jaraco]

I hadn’t read this thread before accepting the PR (I probably should have). I do think the proposed approach is more robust than the one that was used previously, so I’m happy to see it incorporated, even if it is using behavior in discouraged parts of the codebase.

I did not intend to countermand Benoit’s opinion. Happy to revert at your discretion, @benoit-pierre.