Calling fixtures directly error not working with fixtures that yield data

Since the changes in #4561, doing something like this will throw an error (this is the expected behavior):

import pytest

@pytest.fixture
def test():
    return 1

def test_succeed(test):
    assert 1 == test

test()

==================================== ERRORS ====================================
_______________________ ERROR collecting sscce_pytest.py _______________________
sscce_pytest.py:10: in <module>
    test()
E   RemovedInPytest4Warning: Fixture "test" called directly. Fixtures are not meant to be called directly, are created automatically when test functions request them as parameters. See https://docs.pytest.org/en/latest/fixture.html for more information.
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.23 seconds ============================

If I use a fixture that yields a value instead of returning one (detailed in https://docs.pytest.org/en/latest/fixture.html#fixture-finalization-executing-teardown-code) like this:

import pytest

@pytest.fixture
def test():
    yield 1

def test_succeed(test):
    assert 1 == test

test()

the code will succeed when it should throw an error like in the previous example.

I tested it with pytest 4.0.2 running inside a virtualenv on a NixOS GNU/Linux distribution.

Here’s a quick checklist in what to include:

• Include a detailed description of the bug or suggestion
• pip list of the virtual environment you are using
• pytest and operating system versions
• Minimal example if possible

[RonnyPfannschmidt]

@asottile thanks for validating the current code against this

[cript0nauta]

Oh you’re right, it’s fixed on the features branch. Thanks!