Confusing log for teardown

Description

For test files where the last test is skipped, if module level teardown incurs exception, the exception would still be attributed to the skipped test.

Example

1. Save the following snippet as test.py

import pytest

def teardown_module():
    print('executed teardown')
    raise RuntimeError()

def test_test():
    print('executed test')
    pass

@pytest.mark.skip(reason='something')
def test_skipped():
    print('executed skipped')
    pass

1. run pytest -v test.py

2. output

% pytest -v test.py
==================================================================== test session starts =====================================================================
platform darwin -- Python 3.7.7, pytest-5.4.1, py-1.8.0, pluggy-0.13.1 -- /usr/local/opt/python/bin/python3.7
cachedir: xx
rootdir: xx
plugins: env-0.6.2, xdist-1.31.0, forked-1.1.3, cov-2.8.1
collected 2 items

test.py::test_test PASSED                                                                                                                         [ 50%]
test.py::test_skipped SKIPPED                                                                                                                     [100%]
test.py::test_skipped ERROR                                                                                                                       [100%]

=========================================================================== ERRORS ===========================================================================
_____________________________________________________________ ERROR at teardown of test_skipped ______________________________________________________________

    def teardown_module():
        print('executed teardown')
>       raise RuntimeError()
E       RuntimeError

test.py:5: RuntimeError
------------------------------------------------------------------ Captured stdout teardown ------------------------------------------------------------------
executed teardown
================================================================== short test summary info ===================================================================
ERROR test.py::test_skipped - RuntimeError
=========================================================== 1 passed, 1 skipped, 1 error in 0.21s ============================================================

Env

OSX w/ pytest 5.4.1

[Zac-HD]

I think this is working as intended - while it might be unintuitive, changing where we report teardown errors depending on skipped status (which can be decided within the test, and potentially nondeterministically!) is likely to cause worse problems.

[RonnyPfannschmidt]

setting this as duplicate of #895