question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

BROTLI_MODE_* constants are named differently in _brotlimodule.cc

See original GitHub issue

Would it be possible to add MODE_GENERIC, MODE_TEXT and MODE_FONT to brotlipy? Or do you think those should be renamed in the upstream bindings?

See https://github.com/google/brotli/blob/master/python/brotlimodule.cc#L296-L298

I use them like this: https://github.com/behdad/fonttools/blob/master/Lib/fontTools/ttLib/woff2.py#L217 https://github.com/behdad/fonttools/blob/master/Lib/fontTools/ttLib/woff2.py#L375

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
Lukasacommented, Aug 17, 2016

I did not.

For OS X and Windows I use the same Jenkins build farm as the pyca/cryptography folks, which they kindly lent me access to for this job. It’s pretty minor: it just downloads the sdist and builds wheels from it, which I then download, sign, and upload.

For Linux I use a collection of scripts and dockerfiles that was forked from more work done by the cryptography folks (this time for building wheels for CFFI, which incidentally means that the CFFI-based brotlipy actually requires no compilation of any kind on 99% of systems). This uses docker on my local machine, along with the docker manylinux1 image, to build manylinux1 wheels from the sdist.

So far this is a pretty good workflow. Almost all of the work here is built on top of things that @reaperhulk initially did, which means I owe him a huge debt of gratitude, but it’s really nice to be able to say that brotlipy and all its dependencies can be installed from wheels from PyPI.

1reaction
Lukasacommented, Aug 16, 2016

Ok, v0.5.0 has shipped, including wheels for Mac OS X, Windows, and Linux. =)

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found