Code Quality: Incremental adoption of mypy type checks
See original GitHub issuepoetry
and poetry-core
are full type annotated and checking types by mypy is prepared. However these checks are deactivated for most of the modules.
In this ticket I like to invite everybody to pick one or more modules in poetry
and poetry-core
and fix errors reported by mypy. Please link any PR you are starting to this issue.
In process:
- https://github.com/python-poetry/poetry-core/pull/253
- https://github.com/python-poetry/poetry/pull/5262
- https://github.com/python-poetry/poetry/pull/5260
- https://github.com/python-poetry/poetry/pull/5258
- https://github.com/python-poetry/poetry/pull/5255
- https://github.com/python-poetry/poetry/pull/5399
- https://github.com/python-poetry/poetry/pull/5402
Issue Analytics
- State:
- Created 2 years ago
- Reactions:3
- Comments:13 (13 by maintainers)
Top Results From Across the Web
Our journey to type checking 4 million lines of Python - Dropbox
Dropbox has been one of the first companies to adopt Python static type checking at this scale. These days thousands of projects use...
Read more >Python Typing with mypy: Progressive Type Checking on a ...
How to implement incremental type checking during a Hackathon in just 3 days! Python is a duck typed language, meaning it doesn't verify ......
Read more >Using mypy for Python type checking - MLOps.systems
We slowly wind down our discussion of type hints in Python code and think through using mypy and how to introduce type hints...
Read more >Mypy Documentation - Read the Docs
It makes it easy to adopt mypy incrementally. In order to get useful diagnostics from mypy, you must add type annotations to your...
Read more >Python's “type hints” are a bit of a disappointment to me
The types on stitty-documented code often do depend on the types actually being checked though. Otherwise you need to author to be diligent...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
I intend no upset, I’m here because I think poetry is a good thing, and I’m nothing but grateful to those who’ve got us this far. Please be assured that I am not trying to knock or discourage anyone, my apologies if it seemed otherwise.
But yeah, my experience is that contributing to poetry generally is a slow business. Probably #4595 would have been a better place to talk about it though.
Hi @abn, @finswimmer @branchvincent , I will take up poetry.mixology to solve for mypy errors, as there is already an open PR for poetry.console