enable `--ansi` by default on Windows

• I have searched the issues of this repo and believe that this is not a duplicate.
• I have searched the documentation and believe that my question is not covered.

Feature Request

The --ansi option should be default on Windows.

On a fresh install of Windows 10 with a fresh install of the Windows version of Python 3.9.0 Install Poetry via:

py -m pip install --user pipx
py -m pipx ensurepath
# need to get a new console now for pipx to be on PATH
pipx install poetry

Now in both PowerShell and in cmd.exe running pipx --ansi produces nice colors.

Is there a reason not to default --ansi on Windows?

[TBBle]

I also see Poetry 1.2.0a2 failing to auto-detect ANSI support:

• Windows Terminal Preview 1.10.1933.0
• PowerShell 7.1.3
• Python 3.9.6
• pipx 0.16.4

The ANSICON env-var workaround still successfully enables ANSI.

(Ignore the warning about Poetry already existing, that’s noticing my Poetry 1.1.7 installation)

I also checked pipx run --spec poetry==1.2.0a1 poetry just in case it was working in a1 but broken in a2, but the result was the same.

I just checked, and the faulty code that was in clickit (see https://github.com/sdispater/clikit/issues/35#issuecomment-751977044) is still unchanged in cleo 1.0.0a4, so the bug is still in the underlying library: Cleo only auto-detects ANSI for Windows if it can turn on ENABLE_VIRTUAL_TERMINAL_PROCESSING, but not if it is already turned on, as is the case for Windows Terminal or other ConPTY-supporting terminal emulators.

I raised a new issue at https://github.com/sdispater/cleo/issues/104

[Jhraumg]

I could reproduce it from my Windows Terminal + git bash and poetry 1.1.6 (while it worked flawlessly with the same git bash and cmder)

With poetry version 1.2.0a1, it seems all fixed (thanks to #3618 I guess):

• poetry displays color automaticaly on Windows Terminal
• poetry does accept global parameter before command (which could help aliasing poetry to poetry --ansi, but it is non necessary anyway 😉 )