InvalidVersion: Inconsistency in version handling

• I am on the latest Poetry version.
• I have searched the issues of this repo and believe that this is not a duplicate.
• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

• OS version and name: Running in Github Actions on ubuntu-latest
• Poetry version: 1.0.8
• Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/djjudas21/c239c36a51385f40f7b97baa751027a5

Issue

I’m using Poetry in a Github Actions pipeline to set the version based on the git tag, and then to build and publish my project. My pipeline is configured like this but effectively runs:

poetry version <git tag>
poetry publish -n --build --username __token__ --password ${{ secrets.pypi_password }}

The git tag is a semver with an optional trailing name and the poetry version command succeeds in setting the version, but then poetry publish rejects the version. In this case the version is 0.9.4-poetry5 and it yields the following output:

# Run poetry version 0.9.4-poetry5
Bumping version from 0.0.0 to 0.9.4-poetry5

# Run poetry publish -n --build --username __token__ --password ***

[InvalidVersion]
Invalid version: '0.9.4-poetry5'
##[error]Process completed with exit code 1.

Full output of the pipeline is available.

Why does Poetry accept the version in poetry version and later reject it in poetry publish? Thanks

[eikevons]

IMHO, restricting versions to the PEP 440 regex excludes a lot of use-cases.

[alexifm]

I think I have a similar problem. I want to publish a temporary branch version with this: X.Y.Z-<branch>+<build>

poetry version has no problem with that but poetry build can’t handle it.

Here are a couple of tests:

$ poetry build -vvv
Using virtualenv: /Users/alexifm/.pyenv/versions/3.7.7/envs/test
Building test_package (0.2.2-dev+1596889372)
 - Building sdist
 - Adding: test_package/__init__.py
 - Adding: pyproject.toml
 - Built test_package-0.2.2.dev0+1596889372.tar.gz

 - Building wheel
 - Adding: /var/folders/qh/sgf65ggd7z91nhh8hx8fffyw0000gp/T/tmp1u8dp4ad/test_package-0.2.2.dev0+1596889372/test_package/__init__.py
 - Built test_package-0.2.2.dev0+1596889372-py3-none-any.whl

$ poetry build -vvv
Using virtualenv: /Users/alexifm/.pyenv/versions/3.7.7/envs/test
Building test_package (0.2.2-test+1596889372)

[InvalidVersion]
Invalid version: '0.2.2-test+1596889372'

Traceback (most recent call last):
  File "/usr/local/Cellar/poetry/1.0.10/libexec/vendor/lib/python3.8/site-packages/clikit/console_application.py", line 131, in run
    status_code = command.handle(parsed_args, io)
  File "/usr/local/Cellar/poetry/1.0.10/libexec/vendor/lib/python3.8/site-packages/clikit/api/command/command.py", line 120, in handle
    status_code = self._do_handle(args, io)
  File "/usr/local/Cellar/poetry/1.0.10/libexec/vendor/lib/python3.8/site-packages/clikit/api/command/command.py", line 171, in _do_handle
    return getattr(handler, handler_method)(args, io, self)
  File "/usr/local/Cellar/poetry/1.0.10/libexec/vendor/lib/python3.8/site-packages/cleo/commands/command.py", line 92, in wrap_handle
    return self.handle()
  File "/usr/local/Cellar/poetry/1.0.10/libexec/lib/python3.8/site-packages/poetry/console/commands/build.py", line 30, in handle
    builder.build(fmt)
  File "/usr/local/Cellar/poetry/1.0.10/libexec/lib/python3.8/site-packages/poetry/masonry/builder.py", line 19, in build
    builder = self._FORMATS[fmt](self._poetry, self._env, self._io)
  File "/usr/local/Cellar/poetry/1.0.10/libexec/lib/python3.8/site-packages/poetry/masonry/builders/builder.py", line 71, in __init__
    self._meta = Metadata.from_package(self._package)
  File "/usr/local/Cellar/poetry/1.0.10/libexec/lib/python3.8/site-packages/poetry/masonry/metadata.py", line 46, in from_package
    meta.version = normalize_version(package.version.text)
  File "/usr/local/Cellar/poetry/1.0.10/libexec/lib/python3.8/site-packages/poetry/utils/helpers.py", line 34, in normalize_version
    return str(Version(version))
  File "/usr/local/Cellar/poetry/1.0.10/libexec/lib/python3.8/site-packages/poetry/version/version.py", line 56, in __init__
    raise InvalidVersion("Invalid version: '{0}'".format(version))

It’s coming from here: https://github.com/python-poetry/poetry/blob/1.0.10/poetry/utils/helpers.py#L33-L34 https://github.com/python-poetry/poetry/blob/1.0.10/poetry/version/version.py#L14-L56

The regex has a particularly demanding format because while official SemVer says the prerelease component can be an arbitrary string, Python opts for this particular form which Poetry is using: https://semver.org/#spec-item-9 https://www.python.org/dev/peps/pep-0440/