`poetry install` in 3.5 env - "AttributeError: 'PosixPath' object has no attribute 'endswith'"

• Poetry version: 1.2.2

• Python version: System python : 3.10.8, env version: 3.5.10

• OS version and name: Linux (Manjaro)

• pyproject.toml: https://github.com/alorence/django-modern-rpc/blob/better-dependencies-management/pyproject.toml

• [ x ] I am on the latest stable Poetry version, installed using a recommended method.

• [ x ] I have searched the issues of this repo and believe that this is not a duplicate.

• [ x ] I have consulted the FAQ and blog for any relevant entries or release notes.

• [ x ] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

I am managing a FOSS project with Python 3.5 and 3.6 support. I know that Poetry runs only on Python 3.7+, but I assume I can use it with my python system (3.10) while working in an environment:

❯ python -V
Python 3.10.8
❯ pyenv local   
system
3.11
3.5
❯ poetry env use 3.5
Creating virtualenv django-modern-rpc-4Wp8Q-da-py3.5 in /home/alorence/.cache/pypoetry/virtualenvs
Using virtualenv: /home/alorence/.cache/pypoetry/virtualenvs/django-modern-rpc-4Wp8Q-da-py3.5
❯ poetry run python -V
Python 3.5.10

Now, I try to install the dependencies inside the 3.5 environment:

❯ poetry install -vvv
Loading configuration file /home/alorence/.config/pypoetry/config.toml
Using virtualenv: /home/alorence/.cache/pypoetry/virtualenvs/django-modern-rpc-4Wp8Q-da-py3.5
Project environment contains an empty path in sys_path, ignoring.
Installing dependencies from lock file

Finding the necessary packages for the current system

Package operations: 33 installs, 0 updates, 0 removals, 1 skipped

  • Installing zipp (1.2.0): Pending...
[keyring.backend] Loading KWallet
[keyring.backend] Loading SecretService
[keyring.backend] Loading Windows
[keyring.backend] Loading chainer
[keyring.backend] Loading libsecret
[keyring.backend] Loading macOS
Creating new session for pypi.org
[urllib3.connectionpool] Starting new HTTPS connection (1): pypi.org:443
[urllib3.connectionpool] https://pypi.org:443 "GET /pypi/zipp/1.2.0/json HTTP/1.1" 304 0
  • Installing zipp (1.2.0): Failed

  Stack trace:

  1  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/utils/env.py:1459 in _run
      1457│ 
      1458│             if input_:
    → 1459│                 output = subprocess.run(
      1460│                     command,
      1461│                     stdout=subprocess.PIPE,

  CalledProcessError

  Command '['/home/alorence/.cache/pypoetry/virtualenvs/django-modern-rpc-4Wp8Q-da-py3.5/bin/python', '-W', 'ignore', '-']' returned non-zero exit status 1.

  at /usr/lib/python3.10/subprocess.py:526 in run
       522│             # We don't call process.wait() as .__exit__ does that for us.
       523│             raise
       524│         retcode = process.poll()
       525│         if check and retcode:
    →  526│             raise CalledProcessError(retcode, process.args,
       527│                                      output=stdout, stderr=stderr)
       528│     return CompletedProcess(process.args, retcode, stdout, stderr)
       529│ 
       530│ 

The following error occurred when trying to handle this error:


  Stack trace:

  12  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/installation/executor.py:261 in _execute_operation
       259│ 
       260│             try:
     → 261│                 result = self._do_execute_operation(operation)
       262│             except EnvCommandError as e:
       263│                 if e.e.returncode == -2:

  11  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/installation/executor.py:334 in _do_execute_operation
       332│             return 0
       333│ 
     → 334│         result: int = getattr(self, f"_execute_{method}")(operation)
       335│ 
       336│         if result != 0:

  10  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/installation/executor.py:454 in _execute_install
       452│ 
       453│     def _execute_install(self, operation: Install | Update) -> int:
     → 454│         status_code = self._install(operation)
       455│ 
       456│         self._save_url_reference(operation)

   9  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/installation/executor.py:488 in _install
       486│             archive = self._download_link(operation, Link(package.source_url))
       487│         else:
     → 488│             archive = self._download(operation)
       489│ 
       490│         operation_message = self.get_operation_message(operation)

   8  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/installation/executor.py:633 in _download
       631│ 
       632│     def _download(self, operation: Install | Update) -> Path:
     → 633│         link = self._chooser.choose_for(operation.package)
       634│ 
       635│         if link.yanked:

   7  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/installation/chooser.py:88 in choose_for
        86│                     continue
        87│ 
     →  88│                 if not Wheel(link.filename).is_supported_by_environment(self._env):
        89│                     logger.debug(
        90│                         "Skipping wheel %s as this is not supported by the current"

   6  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/installation/chooser.py:56 in is_supported_by_environment
        54│ 
        55│     def is_supported_by_environment(self, env: Env) -> bool:
     →  56│         return bool(set(env.supported_tags).intersection(self.tags))
        57│ 
        58│ 

   5  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/utils/env.py:1370 in supported_tags
       1368│     def supported_tags(self) -> list[Tag]:
       1369│         if self._supported_tags is None:
     → 1370│             self._supported_tags = self.get_supported_tags()
       1371│ 
       1372│         return self._supported_tags

   4  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/utils/env.py:1674 in get_supported_tags
       1672│ 
       1673│     def get_supported_tags(self) -> list[Tag]:
     → 1674│         output = self.run_python_script(GET_SYS_TAGS)
       1675│         assert isinstance(output, str)
       1676│ 

   3  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/utils/env.py:1438 in run_python_script
       1436│ 
       1437│     def run_python_script(self, content: str, **kwargs: Any) -> int | str:
     → 1438│         return self.run(self._executable, "-W", "ignore", "-", input_=content, **kwargs)
       1439│ 
       1440│     def _run(self, cmd: list[str], **kwargs: Any) -> int | str:

   2  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/utils/env.py:1430 in run
       1428│     def run(self, bin: str, *args: str, **kwargs: Any) -> str | int:
       1429│         cmd = self.get_command_from_bin(bin) + list(args)
     → 1430│         return self._run(cmd, **kwargs)
       1431│ 
       1432│     def run_pip(self, *args: str, **kwargs: Any) -> int | str:

   1  ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/utils/env.py:1712 in _run
       1710│     def _run(self, cmd: list[str], **kwargs: Any) -> int | str:
       1711│         kwargs["env"] = self.get_temp_environ(environ=kwargs.get("env"))
     → 1712│         return super()._run(cmd, **kwargs)
       1713│ 
       1714│     def get_temp_environ(

  EnvCommandError

  Command ['/home/alorence/.cache/pypoetry/virtualenvs/django-modern-rpc-4Wp8Q-da-py3.5/bin/python', '-W', 'ignore', '-'] errored with the following return code 1, and output: 
  Traceback (most recent call last):
    File "<stdin>", line 9, in <module>
    File "<frozen importlib._bootstrap_external>", line 581, in spec_from_file_location
  AttributeError: 'PosixPath' object has no attribute 'endswith'
  input was : 
  import importlib.util
  import json
  import sys
  
  from pathlib import Path
  
  spec = importlib.util.spec_from_file_location(
      "packaging", Path(r"/home/alorence/.local/pipx/venvs/poetry/lib/python3.10/site-packages/packaging/__init__.py")
  )
  packaging = importlib.util.module_from_spec(spec)
  sys.modules[spec.name] = packaging
  
  spec = importlib.util.spec_from_file_location(
      "packaging.tags", Path(r"/home/alorence/.local/pipx/venvs/poetry/lib/python3.10/site-packages/packaging/tags.py")
  )
  packaging_tags = importlib.util.module_from_spec(spec)
  spec.loader.exec_module(packaging_tags)
  
  print(
      json.dumps([(t.interpreter, t.abi, t.platform) for t in packaging_tags.sys_tags()])
  )
  

  at ~/.local/pipx/venvs/poetry/lib/python3.10/site-packages/poetry/utils/env.py:1476 in _run
      1472│                 output = subprocess.check_output(
      1473│                     command, stderr=subprocess.STDOUT, env=env, **kwargs
      1474│                 )
      1475│         except CalledProcessError as e:
    → 1476│             raise EnvCommandError(e, input=input_)
      1477│ 
      1478│         return decode(output)
      1479│ 
      1480│     def execute(self, bin: str, *args: str, **kwargs: Any) -> int:

I think the relevant part is

AttributeError: ‘PosixPath’ object has no attribute ‘endswith’

coming from https://github.com/python-poetry/poetry/blob/d02c71cf0262b4741852a9ca0333db1021ac4b9f/src/poetry/utils/env.py#L71-L73

Giving a Path instance to importlib.util.spec_from_file_location may be problematic in Python 3.5 environment, as explained in the documentation:

New in version 3.4.

Changed in version 3.6: Accepts a path-like object.

[alorence]

Neither dropping support for 3.5 projects nor committing to that support is a decision that I can take - I’d wait for someone to show up who does have such authority before submitting any MRs.

I understand. Maybe this issue should remain open at least until a decision is made to either

• officially drop the support of managing python 3.5 projects or
• find a way to repair this feature

The official poetry 1.2 announce on the blog mentionned only the end of python 2.7 projects support : https://python-poetry.org/blog/announcing-poetry-1.2.0/#dropping-support-for-managing-python-27-projects

[dimbleby]

in the next feature release of Poetry (1.2)

presumably that message comes from the 1.1 codebase, so there’s no need to worry about updating that.

Neither dropping support for 3.5 projects nor committing to that support is a decision that I can take - I’d wait for someone to show up who does have such authority before submitting any MRs.

(of course if you have any ideas about how to achieve what that code is trying to achieve without being stuck at old versions of packaging, that would be great…)