Github backend doesn't work with non-OAuth type apps

Now unless I’m misunderstanding something, this library does not work with github. But not the regular OAuth type apps, regular Github apps. Despite the endpoints and everything being the same, this type of app (which I guess is differentiated by the token) does not support the redirect_state parameter. It kept complaining about the redirect_uri not matching up exactly, despite the exact same set up working with regular OAuth apps.

I solved this by subclassing the backend and overriding the option.

class MyGithubOAuth2(GithubOAuth2):
    REDIRECT_STATE = False

Am I doing something wrong, or was this never tested? Perhaps just not supported? Don’t see anything in the documentation regarding this.

[nkprince007]

We have the same problem too. We’re building a code review application for GitHub and GitLab at https://code.gitmate.io.

Our current implementation of authentication is provided by using OAuth2 with social-auth-django. But owing to several features provided by the GitHub App infrastructure, like increased API rate limitations, one single app account that works on all repos, we’d like to migrate our architecture to work as a GitHub App.

This is not about User-Server OAuth, I’m talking about Server(App)-Server(GitHub) communication.

Although it does not work like OAuth, we need to have some sort of storage mechanism with Django. Using PyJWT with the provided RSA key, there should be some method of generating an access token.

CC @sils @fneu @GitMateIo

[atodorov]

FTR I am using the latest version and my SOCIAL_AUTH_GITHUB_KEY and SOCIAL_AUTH_GITHUB_SECRET are pointing to the values from a GitHub App, not an OAuth app.

The GH app itself is configured with Request user authorization (OAuth) during installation (I don’t think that matters in my case) and points to example.com/complete/github/. Users are perfectly able to authorize my GitHub App and login on the site like they were with the older OAuth app.

I don’t see any particular information about how others’ GitHub Apps are configured (again, not sure if and when that matters) but seems like this feature just works in the most basic use-case and we can close this issue.

I am seeing a different issue (not sure if related). Will post separately.