Remove insignificant test assets
See original GitHub issue@astaff had introduced guideline for test assets in https://github.com/pytorch/audio/pull/759 and we can get rid of the following existing assets.
-
100Hz_44100Hz_16bit_05sec.wav
sine wave, should be replaced by on-the-fly generation. -
440Hz_44100Hz_16bit_05sec.wav
sine wave, should be replaced by on-the-fly generation. -
CommonVoice/cv-corpus-4-2019-12-10/tt/clips/common_voice_tt_00000000.mp3
whitenoise, should be converted to wav so that test does not require mp3 decoder. -
dtmf_30s_stereo.mp3
not used. -
genres/noise/noise.0000.wav
should be replaced by on-the-fly generation. -
kaldi_file.wav
sine wave only contains 20 samples and I do not think this is appropriate for test. -
kaldi_file_8000.wav
sine wave, should prefer on-the-fly generation. -
sinewave.wav
sine wave, should prefer on-the-fly generation. -
steam-train-whistle-daniel_simon.mp3
should be replaced bysteam-train-whistle-daniel_simon.wav
-
test.wav
file generated duringtest_io.py
accidentally checked in -
waves_yesno/0_1_0_1_0_1_1_0.wav
-
whitenoise_1min.mp3
should be replaced by on-the-fly generation. -
whitenoise.mp3
should be replaced by on-the-fly generation. -
whitenoise.wav
should be replaced by on-the-fly generation.
General Direction for replacing assets with on-the-fly generation
- Create Tensor
common_utils.get_sinusoid
common_utils.get_whitenoise
- Get temporary file path
self.get_temp_path('foo.wav')
# suppose this class is composed of `common_utils.TempDirMixin`
- Save wav file
common_utils.save_wav(path, data)
- Load wav file
common_utils.load_wav(path)
Issue Analytics
- State:
- Created 3 years ago
- Comments:14 (14 by maintainers)
Top Results From Across the Web
When to remove insignificant variables? - Cross Validated
I checked the summary of the model which is built on 5 independent variables out which one is not significant with a P-value...
Read more >When Insignificant Results are Significant - Optimizely
When running an A/B test, you typically want to see a clear winner. But that doesn't always happen. Sometimes results are insignificant.
Read more >5.2 Impairment of long-lived assets to be held and used
The first step in the impairment test is to determine whether the long-lived assets are recoverable, determined by comparing the net carrying ...
Read more >Deleting test assets - IBM
In the Test Navigator, right-click the test asset, and then select Delete. The following table summarizes how deleting an asset affects the other...
Read more >Final Rule: Amendments to Financial Disclosures ... - SEC.gov
Disclosure Requirements for Individually Insignificant Acquisitions . ... did not propose to substantively revise the Asset Test; however, ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Hi @engineerchuan
I am sorry I replied you in very rushed manner and I gave you a wrong description which ended up confusing you.
Yes, that makes sense.
Yes, you are right. I updated the list.
Thanks for checking the details I missed.
Let me get back on this one.
This is my overlook. I only
grep
ed each asset name so files I did not see the files indirectly required by Dataset implementations. Thanks for pointing this out.You are right, we cannot remove the file because it’s used by
test_io.py
, however, the other teststest_librosa_compatibility
should not be using these files and they should usewav
version instead.Update: The following applies to tests other than
test_io.py
We want to replace this withwav
format. The reason is loadingmp3
file as Tensor is a bit complicated with 3rd party libraries (the tests for non-I/O functionalities should not be usingtorchauiod.load
), and as far as I checked, the tests that usesteam-train-whistle-daniel_simon.mp3
do not have requirement to usemp3
file. So by changing it towav
, we can simplify the test logic and that allows us to run the same test on Windows.